Merge PR #193 into 16.0

Signed-off-by dreispt
OCA · Apr 6, 2024 · 6d71cd0 · 6d71cd0
2 parents 8eda52d + 137e3e5
commit 6d71cd0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/product_standard_margin/models/product_product.py b/product_standard_margin/models/product_product.py
@@ -52,7 +52,7 @@ class ProductProduct(models.Model):
 
     # Compute Section
     @api.depends(
-        "list_price",
+        "lst_price",
         "product_tmpl_id.list_price",
         "standard_price",
         "taxes_id.price_include",
@@ -62,7 +62,7 @@ class ProductProduct(models.Model):
     def _compute_margin(self):
         for product in self:
             product.list_price_vat_excl = product.taxes_id.compute_all(
-                product.list_price, product=product
+                product.lst_price, product=product
             )["total_excluded"]
             product.standard_margin = (
                 product.list_price_vat_excl - product.standard_price

diff --git a/product_standard_margin/tests/test_module.py b/product_standard_margin/tests/test_module.py
@@ -14,18 +14,19 @@ def setUpClass(cls):
 
     # Custom Section
     def _create_product(self, model, standard_price, sale_price, sale_tax_ids):
+        vals = {
+            "name": "Demo Product",
+            "standard_price": standard_price,
+            "taxes_id": [(6, 0, sale_tax_ids)],
+        }
         if model == "product":
             ModelObj = self.ProductProduct
+            vals.update({"lst_price": sale_price})
         else:
             ModelObj = self.ProductTemplate
-        return ModelObj.create(
-            {
-                "name": "Demo Product",
-                "standard_price": standard_price,
-                "list_price": sale_price,
-                "taxes_id": [(6, 0, sale_tax_ids)],
-            }
-        )
+            vals.update({"list_price": sale_price})
+
+        return ModelObj.create(vals)
 
     # Test Section
     def test_01_classic_margin(self):