[16.0][FIX] l10n_it_delivery_note: create delivery note only after quantity done has been set #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarcoCalcagni, @renda-dev, @aleuffre, |
are-agilebg
force-pushed
the
16.0-l10n_it_delivery_note-fix-product-qty
branch
4 times, most recently
from
be8bd99 to
d3b9b6f
Compare
tafaRU
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Grazie 1K della PR! Review del codice 👍
Solo giusto un paio di nitpick:
- aggiunta di un commento alla parte di codice modificata
- modificare il commit message come indicato su https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message
The method stock_picking.button_validate() can be invoked multiple times during the validation process: it is important to create the delivery note only after the stock_move.quantity_done values has been updated otherwise delivery note and picking will be misaligned.
are-agilebg
force-pushed
the
16.0-l10n_it_delivery_note-fix-product-qty
branch
from
d3b9b6f to
4a49a7d
Compare
tafaRU
approved these changes
Jan 16, 2025
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8a0a8d8. Thanks a lot for contributing to OCA. ❤️ |
Closed
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I documenti di trasporto generati utilizzando la modalità Base e lasciando che sia Odoo ad impostare le quantità completate nel trasferimento (You have not recorded done quantities yet, by clicking on apply Odoo will process all the quantities) riportano le quantità prodotto erroneamente a 0.
Il problema nasce dal fatto che all'intero del metodo stock_picking.button_validate() la creazione del documento di trasporto precede l'aggiornamento delle quantità completate nel trasferimento di origine.
Passi per riprodurre la problematica su Runboat: