[16.0] [FIX] l10n_it_fatturapa_in: Il codice fiscale non sembra corretto #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
eLBati
force-pushed
the
16.0-fix-l10n_it_fatturapa_in-company_fiscal_code
branch
2 times, most recently
from
d668c01 to
b867c13
Compare
3 tasks
eLBati
force-pushed
the
16.0-fix-l10n_it_fatturapa_in-company_fiscal_code
branch
from
b867c13 to
af29574
Compare
|
This PR has the |
TheMule71
requested changes
Mar 4, 2024
| """`fiscal_code` is the Fiscal Code of a Person.""" | ||
| return len(fiscal_code) == 16 | ||
|
|
||
|
|
||
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| @api.constrains("fiscalcode") |
There was a problem hiding this comment.
Non ci vorrebbe un controllo anche nel caso cambiasse company_type?
In pratica dovrebbe essere possibile cambiare solo con:
partner.write({"company_type": whatever, "fiscalcode": False})
partner.write({"company_type": "person", "fiscalcode": string_of_len16})
partner.write({"company_type": "company", "fiscalcode": string_of_len11})
There was a problem hiding this comment.
Non ci vorrebbe un controllo anche nel caso cambiasse
company_type?
È stato aggiunto da poco in eb161c7.
SirAionTech
added
the
needs fixing
[IMP] l10n_it_fiscalcode: Check Company Fiscal Code
eLBati
force-pushed
the
16.0-fix-l10n_it_fatturapa_in-company_fiscal_code
branch
from
1526a08 to
afdd435
Compare
|
conflitti risolti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3528