Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] l10n_it_riba: remove account and journal domain #3928

Merged
merged 1 commit into from
May 22, 2024
Merged

[16.0][FIX] l10n_it_riba: remove account and journal domain #3928

merged 1 commit into from
May 22, 2024

Conversation

odooNextev
Copy link
Contributor

Questa fix permette di ammettere che sia il conto portafoglio (accettazione) che il conto di accredito (quello che si muove in D) siano dei conti outstanding che riportano la scadenza.
In questo modo anche chi utilizza questo modulo dovrebbe in futuro poter convergere ad odoo standard in modo semplice.

https://discord.com/channels/753902328494424064/753902328494424070/1200197828044140584

@odooNextev odooNextev changed the title [FIX] l10n_it_riba: remove account and journal domain [16.0][FIX] l10n_it_riba: remove account and journal domain Feb 5, 2024
@stenext stenext force-pushed the 16.0-fix-l10n_it_riba_nodomain branch 4 times, most recently from 66f773f to b20dd67 Compare February 6, 2024 14:11
SirAionTech
SirAionTech approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto solo revisione del codice e per me è ok.
Puoi aprire la issue di tracciamento? Vedi https://github.com/OCA/l10n-italy/wiki/Team-di-sviluppo#apertura-issue.

@marco-marchiori puoi vedere se è quello che intendevi in https://discord.com/channels/753902328494424064/753902328494424070/1200197828044140584?

@odooNextev odooNextev mentioned this pull request Feb 14, 2024
Open
2 tasks
@stenext stenext force-pushed the 16.0-fix-l10n_it_riba_nodomain branch from b20dd67 to 5a9fff4 Compare May 10, 2024 08:15
andreampiovesana
andreampiovesana approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odooNextev
Copy link
Contributor Author

@OCA/local-italy-maintainers quando riuscite si può mergiare?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@andreampiovesana
Copy link
Contributor

merge?

eLBati
eLBati requested changes May 21, 2024
View reviewed changes
l10n_it_riba/readme/CONTRIBUTORS.rst Outdated
* `Aion Tech <https://aiontech.company/>`_:

* Simone Rubino <simone.rubino@aion-tech.it>
* Nextev Srl <odoo@nextev.it>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non andrebbe modificato il CONTRIBUTORS.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hai ragione, comunque per semplicità tolgo il file e lascio la modifica dei contributors per la prossima PR dell'esposizione sempre delle riba

@stenext stenext force-pushed the 16.0-fix-l10n_it_riba_nodomain branch from 5a9fff4 to 1364b68 Compare May 21, 2024 07:29
@odooNextev odooNextev requested a review from eLBati May 21, 2024 07:29
@eLBati
Copy link
Member

eLBati commented May 22, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3928-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b165244 into OCA:16.0 May 22, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f2d38cb. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops francesco-ooops linked an issue May 22, 2024 that may be closed by this pull request
[FIX] l10n_it_riba: rimuovere il dominio tipo banca per conti e registri #3956
Open
2 tasks
@TheMule71 TheMule71 mentioned this pull request Nov 15, 2024
Open
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@eLBati eLBati Awaiting requested review from eLBati

Assignees
No one assigned
Labels
16.0 merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] l10n_it_riba: rimuovere il dominio tipo banca per conti e registri
6 participants
@odooNextev @OCA-git-bot @andreampiovesana @eLBati @SirAionTech @francesco-ooops