Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][l10n_it_intrastat_statement] Code optimization when generating the statement #3882

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[14.0][l10n_it_intrastat_statement] Code optimization when generating the statement #3882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 22 additions & 24 deletions l10n_it_intrastat_statement/models/intrastat_statement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,33 +779,31 @@ def compute_statement(self):
inv_type += ["in_invoice", "in_refund"]
domain.append(("move_type", "in", inv_type))

statement_data = dict()
statement_data = {}
section_field_reverse = {}
for section_type in ["purchase", "sale"]:
for section_number in range(1, 5):
statement_section_field = self.get_section_field_name(
section_type, section_number
)
statement_data[statement_section_field] = list()
section_field_reverse["{}_s{}".format(section_type, section_number)] = (
section_type,
section_number,
)

invoices = self.env["account.move"].search(domain)

for inv_intra_line in invoices.mapped("intrastat_line_ids"):
for section_type in ["purchase", "sale"]:
for section_number in range(1, 5):
section_details = (section_type, section_number)
statement_section = "%s_s%s" % section_details
if inv_intra_line.statement_section != statement_section:
continue
statement_section_model_name = self.get_section_model(
*section_details
)
st_line = self.env[
statement_section_model_name
]._prepare_statement_line(inv_intra_line, self)
if not st_line:
continue
statement_section_field = self.get_section_field_name(
*section_details
)
if statement_section_field not in statement_data:
statement_data[statement_section_field] = list()
st_line["sequence"] = (
len(statement_data[statement_section_field]) + 1
)
statement_data[statement_section_field].append((0, 0, st_line))
section_details = section_field_reverse[inv_intra_line.statement_section]
statement_section_model_name = self.get_section_model(*section_details)
st_line = self.env[statement_section_model_name]._prepare_statement_line(
inv_intra_line, self
)
if st_line:
statement_section_field = self.get_section_field_name(*section_details)
st_line["sequence"] = len(statement_data[statement_section_field]) + 1
statement_data[statement_section_field].append((0, 0, st_line))

self.write(statement_data)
# Group refund to sale lines if they have the same period of ref
Expand Down
Loading