Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [FIX] l10n_it_delivery_note: fix select exist #3853

Closed
wants to merge 1 commit into from
Closed

[14.0] [FIX] l10n_it_delivery_note: fix select exist #3853

wants to merge 1 commit into from

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Jan 16, 2024 •
edited
Loading

Risolve #3907

@OCA-git-bot
Copy link
Contributor

Hi @renda-dev, @aleuffre, @MarcoCalcagni,
some modules you are maintaining are being modified, check this out!

@francesco-ooops
Copy link
Contributor

@Borruso issue? vorremmo analizzare più nello specifico la questione

@Borruso Borruso force-pushed the 14.0-fix-l10n_it_delivery_note-fix_select_exist branch from 9ada38c to 0ca9539 Compare January 26, 2024 09:00
@Borruso Borruso mentioned this pull request Jan 26, 2024
Open
2 tasks
@francesco-ooops francesco-ooops linked an issue Jan 26, 2024 that may be closed by this pull request
[FIX] l10n_it_delivery_note: non si riesce a legare allo stesso DdT due picking derivate da stesso ordine #3907
Open
2 tasks
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 16, 2024
@Borruso Borruso force-pushed the 14.0-fix-l10n_it_delivery_note-fix_select_exist branch from 0ca9539 to b87ba76 Compare July 26, 2024 08:20
aleuffre
aleuffre reviewed Jul 26, 2024
View reviewed changes
l10n_it_delivery_note/wizard/delivery_note_select.py Outdated
Comment on lines 38 to 41
if self.selected_picking_ids.mapped("sale_id.partner_id"):
self.partner_id = self.selected_picking_ids.mapped(
"sale_id.partner_id"
).id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Suggested change
if self.selected_picking_ids.mapped("sale_id.partner_id"):
self.partner_id = self.selected_picking_ids.mapped(
"sale_id.partner_id"
).id
self.partner_id = self.selected_picking_ids.mapped("sale_id.partner_id")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie per la segnalazione

@Borruso Borruso force-pushed the 14.0-fix-l10n_it_delivery_note-fix_select_exist branch from b87ba76 to 606853c Compare July 26, 2024 09:49
@Borruso Borruso force-pushed the 14.0-fix-l10n_it_delivery_note-fix_select_exist branch from 606853c to 046d6b1 Compare July 26, 2024 09:56
@francesco-ooops francesco-ooops removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 26, 2024
@TheMule71 TheMule71 mentioned this pull request Nov 15, 2024
Open
33 tasks
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
@github-actions github-actions bot closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre left review comments

Assignees
No one assigned
Labels
14.0 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] l10n_it_delivery_note: non si riesce a legare allo stesso DdT due picking derivate da stesso ordine
4 participants
@Borruso @OCA-git-bot @francesco-ooops @aleuffre