New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_website_sale_fiscalcode: fix fiscalcode check #3592

Merged

OCA-git-bot merged 1 commit into OCA:14.0 from FrancescoBallerini:14.0-l10n_it_website_sale_fiscalcode_fix_fiscalcode_check

Feb 28, 2024

Contributor

FrancescoBallerini commented Sep 20, 2023 •

edited

Loading

Implement

This commit restores the call to the constrains check_fiscalcode() in checkout_form_validate() method of WebsiteSale controller (#3588). The company_name will also be added to the dummy partned so the field value will be correctly evaluated on the constrains (#3591).

baba75 approved these changes

View reviewed changes

baba75 left a comment

Testato su runboat funziona correttamente

andreampiovesana approved these changes

View reviewed changes

Contributor

andreampiovesana left a comment

LGTM

OCA-git-bot added the approved label

francesco-ooops added the 14.0 label

francesco-ooops linked an issue

that may be closed by this pull request

[14.0] l10n_it_website_sale_fiscalcode: missing check_fiscalcode() call #3588

Closed

2 tasks

francesco-ooops mentioned this pull request

l10n_it_website_sale_fiscalcode: company_name not evaluated in checkout_form_validate() #3591

Closed

2 tasks

francesco-ooops linked an issue

that may be closed by this pull request

l10n_it_website_sale_fiscalcode: company_name not evaluated in checkout_form_validate() #3591

Closed

2 tasks

francesco-ooops mentioned this pull request

[14.0] l10n_it_website_sale_fiscalcode: missing check_fiscalcode() call #3588

Closed

2 tasks

sergiocorato reviewed

View reviewed changes

l10n_it_website_sale_fiscalcode/controllers/main.py Show resolved Hide resolved

Contributor

sergiocorato commented Feb 27, 2024

/ocabot rebase


          [14.0][FIX] l10n_it_website_sale_fiscalcode: fix fiscalcode check

894de6c

Implement

- OCA#3588
- OCA#3591

This commit restores the call to the constrains `check_fiscalcode()`
in `checkout_form_validate()` method of `WebsiteSale` controller (OCA#3558).
The `company_name` will also be added to the dummy partned so the field
value will be correctly evaluated on the constrains (OCA#3591).

Contributor

OCA-git-bot commented Feb 27, 2024

Congratulations, PR rebased to 14.0.

OCA-git-bot force-pushed the 14.0-l10n_it_website_sale_fiscalcode_fix_fiscalcode_check branch from 766576c to 894de6c Compare

February 27, 2024 17:15

Contributor

sergiocorato commented Feb 28, 2024

/ocabot merge minor

Contributor

OCA-git-bot commented Feb 28, 2024

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

5734b86

Signed-off-by sergiocorato

OCA-git-bot added the bot is merging ⏳ label

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

58e4dde

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

db27ac3

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

2a6376f

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

c7407eb

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

e752d1d

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request


          Merge PR #3592 into 14.0

e19a674

Signed-off-by sergiocorato

Contributor

OCA-git-bot commented Feb 28, 2024

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3592-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot merged commit c64d0db into OCA:14.0

5 of 7 checks passed

Contributor

OCA-git-bot commented Feb 28, 2024

Congratulations, your PR was merged at bd25a17. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

14.0 approved merged 🎉