Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [FIX] set l10n_it_fatturapa_out XML templates as not translatable #3008

Merged
merged 4 commits into from
Nov 10, 2023
Merged

[14.0] [FIX] set l10n_it_fatturapa_out XML templates as not translatable #3008

merged 4 commits into from
Nov 10, 2023

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Nov 7, 2022 •
edited
Loading

Risolve #3006

@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 6377e34 to af8b24f Compare November 7, 2022 15:07
@primes2h primes2h marked this pull request as draft November 7, 2022 15:19
@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch 6 times, most recently from 072a6fb to 21a030d Compare November 7, 2022 17:23
@primes2h primes2h marked this pull request as ready for review November 7, 2022 17:23
This was referenced Nov 7, 2022
Closed
Closed
@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch 3 times, most recently from 3b0cf37 to bb91672 Compare November 7, 2022 20:50
@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch 2 times, most recently from 07655f3 to 1e9ca62 Compare December 28, 2022 13:31
@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 1e9ca62 to 827bdbd Compare February 23, 2023 16:39
sergiocorato
sergiocorato approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@sergiocorato sergiocorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiocorato
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@OCA-git-bot OCA-git-bot force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 827bdbd to 9dbdeff Compare August 29, 2023 19:08
@sergiocorato
Copy link
Contributor

@OCA/local-italy-maintainers questa PR è ferma da un po', non ho seguito la issue iniziale ma mi pare utile da mergiare, che dite?

@tafaRU
Copy link
Member

tafaRU commented Sep 1, 2023

Vedo che lo stesso commit modifica diversi moduli: sarebbe preferibile splittare le modifiche in modo da riuscire più facilmente a farne il FW port.

@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 9dbdeff to 00d970d Compare September 7, 2023 09:14
@primes2h
Copy link
Contributor Author

primes2h commented Sep 7, 2023

Vedo che lo stesso commit modifica diversi moduli: sarebbe preferibile splittare le modifiche in modo da riuscire più facilmente a farne il FW port.

Fatto.

@primes2h
Copy link
Contributor Author

primes2h commented Sep 7, 2023

#3006 (comment)

@sergiocorato
Copy link
Contributor

@primes2h Puoi allineare la PR?

@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 00d970d to 4a2bac0 Compare November 9, 2023 13:50
@primes2h primes2h force-pushed the 14-fix-l10n_it_fatturapa_out-xml_template_strings_in_pot branch from 4a2bac0 to 64dd16a Compare November 9, 2023 14:09
@primes2h
Copy link
Contributor Author

primes2h commented Nov 9, 2023

@primes2h Puoi allineare la PR?

Fatto.

@sergiocorato
Copy link
Contributor

@tafaRU commenti qui?

@tafaRU
Copy link
Member

tafaRU commented Nov 9, 2023 •
edited
Loading

LGTM 👍 (only technical review)

@francesco-ooops
Copy link
Contributor

@francescapenso buona per te?

@sergiocorato
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-3008-by-sergiocorato-bump-patch, awaiting test results.

@francesco-ooops
Copy link
Contributor

@primes2h penso sia tutto a posto per fare fw-porting alla 16 👍

@OCA-git-bot OCA-git-bot merged commit fd2e849 into OCA:14.0 Nov 10, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dafd787. Thanks a lot for contributing to OCA. ❤️

@primes2h
Copy link
Contributor Author

@primes2h penso sia tutto a posto per fare fw-porting alla 16 👍

Eccola #3715

@francescapenso
Copy link

@francescapenso buona per te?

scusate direi di si, cmq vedo che è mergiata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiocorato sergiocorato sergiocorato approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@primes2h @sergiocorato @OCA-git-bot @tafaRU @francesco-ooops @francescapenso