Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_delivery_note: fix partner ddt #2785

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[14.0][FIX] l10n_it_delivery_note: fix partner ddt #2785

merged 1 commit into from
Feb 23, 2024

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented May 11, 2022 •
edited
Loading

Descrizione del problema o della funzionalità:

ricavare i partner da inserire nel DDT se magazzino è di tipo virtuale

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@OCA-git-bot
Copy link
Contributor

Hi @Byloth, @As400it,
some modules you are maintaining are being modified, check this out!

@Borruso Borruso mentioned this pull request Dec 13, 2023
Closed
2 tasks
@francesco-ooops
Copy link
Contributor

@Borruso puoi rilanciare il runboat?

@sergiocorato
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@francesco-ooops francesco-ooops linked an issue Dec 18, 2023 that may be closed by this pull request
Ricavare i partner da inserire nel DDT se ubicazione non ha magazzino #3779
Closed
2 tasks
PicchiSeba
PicchiSeba reviewed Feb 22, 2024
View reviewed changes
l10n_it_delivery_note/models/stock_picking.py Outdated
Comment on lines 386 to 389
if picking_type_code == ["outgoing"]:
src_partner_id = self.company_id.partner_id
else:
src_partner_id = partner_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if picking_type_code == ["outgoing"]:
src_partner_id = self.company_id.partner_id
else:
src_partner_id = partner_id
src_partner_id = self.company_id.partner_id if picking_type_code == ["outgoing"] else partner_id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: personalmente lo preferisco in questa forma se si tratta di un semplice controllo che in entrambi i casi va a modificare solo la stessa variabile

l10n_it_delivery_note/models/stock_picking.py Outdated
Comment on lines 392 to 395
if picking_type_code == ["incoming"]:
dest_partner_id = self.company_id.partner_id
else:
dest_partner_id = partner_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if picking_type_code == ["incoming"]:
dest_partner_id = self.company_id.partner_id
else:
dest_partner_id = partner_id
dest_partner_id = self.company_id.partner_id if picking_type_code == ["incoming"] else partner_id

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: come sopra

@Borruso Borruso force-pushed the 14.0-fix-partner-ddt branch from 8ead37d to d44a5a2 Compare February 23, 2024 09:16
@Borruso Borruso requested a review from PicchiSeba February 23, 2024 09:16
PicchiSeba
PicchiSeba approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@PicchiSeba PicchiSeba left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

aleuffre
aleuffre approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@aleuffre
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-2785-by-aleuffre-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 88cd97e into OCA:14.0 Feb 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e33d988. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@PicchiSeba PicchiSeba PicchiSeba approved these changes

Assignees
No one assigned
Labels
14.0 approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ricavare i partner da inserire nel DDT se ubicazione non ha magazzino
6 participants
@Borruso @OCA-git-bot @francesco-ooops @sergiocorato @aleuffre @PicchiSeba