Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] l10n_it_withholding_tax: reconcile payments after reset invoice to draft #2673

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[14.0][FIX] l10n_it_withholding_tax: reconcile payments after reset invoice to draft #2673

merged 1 commit into from
Feb 26, 2024

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Feb 21, 2022 •
edited by eLBati
Loading

#2637

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso changed the title [FIX] l10n_it_withholding_tax: reconcile payments after reset invoice to draft [14.0][FIX] l10n_it_withholding_tax: reconcile payments after reset invoice to draft Feb 21, 2022
@Borruso Borruso mentioned this pull request Feb 21, 2022
Closed
3 tasks
@Borruso Borruso force-pushed the 14.0-fix-reconcile-payments branch 3 times, most recently from 72de72f to 6bfe46f Compare February 25, 2022 10:45
zeroincombenze
zeroincombenze approved these changes Apr 1, 2022
View reviewed changes
Copy link

@zeroincombenze zeroincombenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Con questa branch non ho riscontrato il problema che invece avevo rilevato con la review #2572

@tafaRU
Copy link
Member

tafaRU commented May 13, 2022

@Borruso puoi gestire i conflitti?

@Borruso Borruso force-pushed the 14.0-fix-reconcile-payments branch from 6bfe46f to b324075 Compare May 13, 2022 13:31
@Borruso Borruso force-pushed the 14.0-fix-reconcile-payments branch from b324075 to 919f789 Compare May 31, 2022 10:32
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francescapenso
Copy link

merge?

SirTakobi
SirTakobi suggested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@SirTakobi SirTakobi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Ho fatto diverse prove (in locale perché la PR non ha runboat) e c'è qualcosa che non mi torna, qui sotto i passi che ho fatto:

  1. Creo una fattura fornitore da 10 + 2,2 con ritenuta del 10% e la confermo, i totali della fattura sono:
    image
  2. Creo un pagamento da 11,2 (nel popup lascio Differenza di pagamento = Tieni aperta) e la fattura risulta correttamente pagata.
  3. Porto in bozza e riconfermo, agganciando i debiti in sospeso creati dal pagamento precedente
  4. I totali della fattura ora sono
    image

Come mai ci sono dei pagamenti extra? È normale che l'importo dovuto sia negativo?

Ho provato gli stessi passi in runboat e in effetti il comportamento è simile: i totali alla fine sono
image
In pratica in runboat vengono generati 3 pagamenti da 1€ per le ritenute, mentre in questa PR vengono generati 4 pagamenti: uno da 1€, uno da 0,99€ e due da 0,9€.
Puoi verificare?

@Borruso Borruso closed this Nov 8, 2023
@matteoopenf
Copy link
Contributor

@Borruso hai chiuso in favore di altro o solo chiuso?

@Borruso Borruso reopened this Nov 8, 2023
@Borruso Borruso force-pushed the 14.0-fix-reconcile-payments branch from 919f789 to 9179d96 Compare November 8, 2023 14:14
@Borruso Borruso force-pushed the 14.0-fix-reconcile-payments branch from 9179d96 to e33b673 Compare November 8, 2023 14:19
@francescapenso
Copy link

è da fare review?

@francesco-ooops francesco-ooops linked an issue Dec 19, 2023 that may be closed by this pull request
doppie scritture per le fatture in regime di ritenuta d’acconto dopo doppia conferma #2637
Closed
3 tasks
@francesco-ooops
Copy link
Contributor

@Borruso ci sono differenze rispetto alla soluzione per v16 mergiata in #3707 ?

@Borruso
Copy link
Contributor Author

Borruso commented Feb 26, 2024

@Borruso ci sono differenze rispetto alla soluzione per v16 mergiata in #3707 ?

non ci sono differenze

@francesco-ooops
Copy link
Contributor

@eLBati si può mergiare anche questa dunque?

@eLBati
Copy link
Member

eLBati commented Feb 26, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2673-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e59bc4e into OCA:14.0 Feb 26, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e936c21. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTakobi SirTakobi SirTakobi requested changes

@are-agilebg are-agilebg are-agilebg approved these changes

@francescapenso francescapenso francescapenso approved these changes

@zeroincombenze zeroincombenze zeroincombenze approved these changes

Assignees
No one assigned
Labels
14.0 merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doppie scritture per le fatture in regime di ritenuta d’acconto dopo doppia conferma
10 participants
@Borruso @tafaRU @OCA-git-bot @francescapenso @matteoopenf @francesco-ooops @eLBati @zeroincombenze @SirTakobi @are-agilebg