Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] delivery_carrier_label_batch: Migration to 18.0 #984

Open
wants to merge 61 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] delivery_carrier_label_batch: Migration to 18.0 #984

wants to merge 61 commits into from

Conversation

yankinmax
Copy link
Contributor

yvaucher and others added 30 commits February 10, 2025 16:45
@yvaucher @yankinmax
[9.0] port module delivery_carrier_label_dispatch
33810ba 
- change name to batch to match with change of `picking_dispatch` name to
`stock_batch_picking`
- mode description in README.rst
- move files in models and views directories
- change headers to small license header
- use api 8.0
- fix and improve tests
@yvaucher @yankinmax
Update translations
5fcf612
@yvaucher @yankinmax
Cannot update options due to limitation of api 8.0
3fc3efd
@mdietrichc2c @yankinmax
Use IDs instead of recordset for write
eabeb1f
@guewen @yankinmax
rename field tracking_id to package_id
b94c46a 
the field has been renamed in the base module
@mdietrichc2c @yankinmax
Remove self.pool + add correct attachment name
1a0bbcb
@mdietrichc2c @yankinmax
View changed in batch_stock_picking
1b58e93
@guewen @yankinmax
Fix condition
95f44dc
@guewen @yankinmax
Thread label generation to make it faster
4cfcec5 
Port of OCA#27
@mdietrichc2c @yankinmax
Fix onchange for batch picking
7e4aa5c
@mdietrichc2c @yankinmax
Correct error treatment
a01adf4
@guewen @yankinmax
Fix empty pdf issue
f90bd31 
Probably due to usage of multiple environment and cache. datas can't be
read from shipping.label but it can be read from ir.attachment
@mdietrichc2c @yankinmax
Add pick/pack info to all exceptions
1952990
@mdietrichc2c @yankinmax
e.message deprecated from 2.6
1ccb288
@guewen @yankinmax
Allow to print labels on operations without product
636d5b2
@guewen @yankinmax
Fix concurrent error on batch labels
6dce0bf 
When there is more than 1 pack in a picking, 2 or more thread worker
might be in concurrence on the same picking, which makes one of the
transaction fails, resulting in the abort of the whole label generation.

The solution implemented is to change the way of passing the tasks to
the thread workers. Instead of passing a label at a time, we pass a
group of label. A group of label actually contains all the labels to
generate for one picking.
@p-tombez @yankinmax
Do not regenerate existing labels unless forced + pylint fix
78d0073
@TDu @yankinmax
[12.0][MIG] delivery_carrier_label_batch
d9605f6
@tschanzt @yankinmax
fixes for cahnges in migration of base_deliver_carrier_label (#1)
365c6c0
@yankinmax
[9.0][ADD] support of zpl labels
57b64bd
@sebalix @yankinmax
[IMP] delivery_carrier_label_batch: add support for ZPL labels
7b8297c
@yankinmax
Fix tests
46f0b93
@yankinmax
add missing _description
e8119de
@grindtildeath @yankinmax
[IMP] delivery_carrier_label_batch: ZPL2 single images
ce5ce7b
@grindtildeath @gurneyalex @yankinmax
Apply suggestions from code review
0ba53a2 
Co-Authored-By: Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
@grindtildeath @yankinmax
Fixes after reviews
e20aa51
@vrenaville @yankinmax
[IMP][ZPL] option to not merge Zpl file (printer failed to print to b…
7e4169d 
…ig files)
@vrenaville @yankinmax
[IMP] label name from batch tracking zpl
4c48f2a
@yvaucher @yankinmax
Add a check that all picking have packs before generating them.
ce6cd19
@yvaucher @yankinmax
label batch: Enforce use of packages
03e7f54 
The support of picking without packages has been dropped following the RFC OCA#192

Since ffaab97 commit `base_delivery_carrier_label` force the usage of
packages.
OCA-git-bot and others added 13 commits February 10, 2025 16:45
@OCA-git-bot @yankinmax
delivery_carrier_label_batch 14.0.1.0.1
2188722
@OCA-git-bot @yankinmax
delivery_carrier_label_batch 14.0.1.0.2
d454cd1
@StephaneMangin @yankinmax
[IMP] delivery_carrier_label_batch: tracking reference purge
31f623d 
Sometimes, when regenerating labels from third party API, we could not get the
new tracking references. And then as we do not purge tracking references
correctly, previous ones are kept and lead to incoherences (batch picking
tracking references emptied but labels still existing). For this we need to
manually purge references when asking for full regeneration.
@OCA-git-bot @yankinmax
delivery_carrier_label_batch 14.0.1.1.0
16da252
@OCA-git-bot @yankinmax
[UPD] README.rst
a058332
@weblate @yankinmax
Update translation files
055bd06 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/
@pedrobaeza @yankinmax
[FIX] *: Linter fixes
593dde5
@OCA-git-bot @yankinmax
[BOT] post-merge updates
72e9f4b
@Ivorra78 @yankinmax
Added translation using Weblate (Spanish)
4746ac5
@Ivorra78 @yankinmax
Translated using Weblate (Spanish)
75e849e 
Currently translated at 2.8% (1 of 35 strings)

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/es/
@Ivorra78 @yankinmax
Translated using Weblate (Spanish)
29a70ae 
Currently translated at 100.0% (35 of 35 strings)

Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_label_batch
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_label_batch/es/
@mymage @yankinmax
Added translation using Weblate (Italian)
edf3446
@yankinmax
[IMP] delivery_carrier_label_batch: pre-commit auto fixes
7246395
@yankinmax
Copy link
Contributor Author

The tests are failing because of the issue I've mentioned in this PR (delivery_postlogistics)

@imlopes imlopes mentioned this pull request Feb 16, 2025
Closed
@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_label_batch

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 17, 2025
Open
22 tasks
@StephaneMangin StephaneMangin mentioned this pull request Feb 18, 2025
Open
@yankinmax yankinmax force-pushed the 18.0-mig-delivery_carrier_label_batch branch 4 times, most recently from a17288a to dd119da Compare February 20, 2025 13:52
@yankinmax yankinmax force-pushed the 18.0-mig-delivery_carrier_label_batch branch from 02b51d3 to 39b2255 Compare February 20, 2025 18:18
@yankinmax yankinmax force-pushed the 18.0-mig-delivery_carrier_label_batch branch from 39b2255 to ca31b7c Compare February 21, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imlopes imlopes imlopes approved these changes

@vvrossem vvrossem vvrossem approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.