-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_manual_currency #1883
[17.0][MIG] account_manual_currency #1883
Conversation
I'm now proposing a separate fix for the tests in #1888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cherry-pick the migration commit from #1650 so as to keep proper history and attribution?
…yment registration. - This feature allows users to utilize currency rate differences from the invoice.
c09f480
to
096461d
Compare
History added to PR. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional and code review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 9d132f8. Thanks a lot for contributing to OCA. ❤️ |
Migration module, applying suggested changes of 16.0 version: #1650
Fix of the test in the module account_invoice_section_sale_order: #1871
@ForgeFlow
@Saran440