Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_manual_currency #1883

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

ThiagoMForgeFlow
Copy link

@ThiagoMForgeFlow ThiagoMForgeFlow commented Jan 20, 2025

Migration module, applying suggested changes of 16.0 version: #1650
Fix of the test in the module account_invoice_section_sale_order: #1871

@ForgeFlow
@Saran440

@StefanRijnhart
Copy link
Member

I'm now proposing a separate fix for the tests in #1888

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cherry-pick the migration commit from #1650 so as to keep proper history and attribution?

@ThiagoMForgeFlow ThiagoMForgeFlow force-pushed the 17.0-mig-account_manual_currency branch from c09f480 to 096461d Compare January 27, 2025 08:10
@ThiagoMForgeFlow
Copy link
Author

Can you cherry-pick the migration commit from #1650 so as to keep proper history and attribution?

History added to PR. Thank you!

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you!

Copy link

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review 👍

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@AaronHForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1883-by-AaronHForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b31b830 into OCA:17.0 Jan 29, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9d132f8. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-mig-account_manual_currency branch January 29, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants