-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] account_financial_report: Add Amount cur. to General Ledger totals if the account has not set currency #1236
Conversation
2240fe7
to
61a0d33
Compare
Still some weird amounts in http://oca-account-financial-reporting-15-0-pr1236-61a0d339a2d6.runboat.odoo-community.org |
Ok, I see what you mean, it shows -1224.01 instead of -601.74, but is it really an error? IMO no, I explain what happens and why. 1224.01=622.27 + 601.74 622.27 is something that although it is not shown on screen in the Amount cur. column (although in the Cumul. Bal. column)., it has been defined in https://github.com/OCA/account-financial-reporting/blob/15.0/account_financial_report/report/general_ledger.py#L150. |
Yeah, I understand, but it's incorrect. You have to only sum in the total if the currency is different from the company one. |
…als if the account has not set currency Related to OCA#1235 (comment)
…General Ledger report
61a0d33
to
32ca933
Compare
Changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 897cde8. Thanks a lot for contributing to OCA. ❤️ |
…Show foreign currency checkbox is not checked. Related to OCA#1236 TT51996
…als if the account has not set currency Related to OCA#1235 (comment) [FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked. Related to OCA#1236 TT51996
…als if the account has not set currency Related to OCA#1235 (comment) [FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked. Related to OCA#1236 TT51996
…als if the account has not set currency Related to OCA#1235 (comment) [FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked. Related to OCA#1236 TT51996
Add Amount cur. to General Ledger totals if the account has not set currency
Related to #1235 (comment)
@Tecnativa