Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] account_financial_report: add custom intervals for aged partner report #1147

Conversation

carolinafernandez-tecnativa
Copy link
Contributor

@carolinafernandez-tecnativa carolinafernandez-tecnativa changed the title [17.0][IMP] account_financial_report: Set custom intervales in aged report [17.0][IMP] account_financial_report: add custom intervals for aged partner report Apr 15, 2024
@pilarvargas-tecnativa
Copy link
Contributor

Can you remove the "or" between the buttons?

<footer>
<button
name="button_export_html"
string="View"
type="object"
default_focus="1"
class="oe_highlight"
/>
or
<button
name="button_export_pdf"
string="Export PDF"
type="object"
/>
or
<button
name="button_export_xlsx"
string="Export XLSX"
type="object"
/>
or
<button string="Cancel" class="oe_link" special="cancel" />
</footer>

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 17.0-imp-account_financial_report-add-custom-intervals branch from 765fd8c to 6c90a94 Compare April 15, 2024 16:27
@carolinafernandez-tecnativa
Copy link
Contributor Author

Can you remove the "or" between the buttons?

<footer>
<button
name="button_export_html"
string="View"
type="object"
default_focus="1"
class="oe_highlight"
/>
or
<button
name="button_export_pdf"
string="Export PDF"
type="object"
/>
or
<button
name="button_export_xlsx"
string="Export XLSX"
type="object"
/>
or
<button string="Cancel" class="oe_link" special="cancel" />
</footer>

Done! thanks :)

@pedrobaeza
Copy link
Member

Pending on the changes to apply in #1140 cc @carolinafernandez-tecnativa

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 17.0-imp-account_financial_report-add-custom-intervals branch from 6c90a94 to 6ea6011 Compare April 21, 2024 13:29
@carolinafernandez-tecnativa
Copy link
Contributor Author

Pending on the changes to apply in #1140 cc @carolinafernandez-tecnativa

Changes added

@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 17.0-imp-account_financial_report-add-custom-intervals branch from 6ea6011 to f9f5145 Compare April 22, 2024 18:19
@carolinafernandez-tecnativa carolinafernandez-tecnativa force-pushed the 17.0-imp-account_financial_report-add-custom-intervals branch from f9f5145 to bf06a25 Compare April 22, 2024 18:20
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👍

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1147-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit ae5676f into OCA:17.0 Apr 23, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9fa0d37. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-imp-account_financial_report-add-custom-intervals branch April 23, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants