[17.0][MIG] account_financial_report #1101

norlinhenrik · 2024-01-24T19:03:01Z

report_action.esm.js caused problems so I disabled the code, since I don't know how to fix it. Anyway, the reports seem to work fine.

Some changes in the databases been made in OCA#403, but no migration is needed.

When this module is installed along with other chart account different from generic one, the number of expected accounts and the computation change (for example, in Spain, the unaffected earnings account is 129000, choking with group with code prefix 1). This commit makes the tests resistent to these changes.

To general ledger

When there are a lot of account.move.line (several millions) and print any of the Qweb reports, that will generate also a lot of transient objects. As these objects are created with an "insert" query, the cleaning normally triggered by the count of the records in transient tables is not done, so only the cleaning based on the age of the records is processed (by default, records older than 1 hours are deleted), but the cron task is only ran one time per day. For large setups this can lead to memory errors at that point. This change prevents the memory error by executing the transient record cleanup for the report models in this module in SQL.

Currently translated at 73.9% (215 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/de/

Currently translated at 50.2% (146 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/

Currently translated at 96.2% (178 of 185 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/ar/

Currently translated at 100.0% (291 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/

Currently translated at 83.5% (243 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/nl/

Currently translated at 100.0% (291 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/

Currently translated at 23.0% (67 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/it/

- Adds 'Period balance' column - Renames the option 'Hide accounts at 0'. Means no initial, no debit, credit or ending balance for the period. - Fixes logic to remove lines with 0 activity for the period. - improve the calculation in the Trial Balance of undistributed profits/losses account, and provide a footer note to the user explaining why will the ending balances will not be zero, but the period's total profit and loss. - add an extra line for P&L application so that the trial balance zeroes in the balance, and total debits = total credits - refactoring of the unaffected earnings reporting in the general ledger and trial balance.

Currently translated at 74.6% (217 of 291 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/de/

)

Currently translated at 96.4% (291 of 302 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/

All reports: - Rename field to hide accounts at 0 to 'hide_account_at_0' Trial Balance: - Add possibility to filter by hierarchy levels - XLSX format will show the hierarchy levels in bold General Ledger: - Add the possibility to filter by analytic tags - Fixes an error on the default date Journal Ledger: - The filter on Journals is now optional. If the user does not choose a journal, by default it will display all journals. Aged Partner Balance: - Fixes an error on the default date

…sability

Currently translated at 39.7% (120 of 302 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/ro/

* Fix account group level computation Depends was not correct for recomputing when needed + better algorithm * Make hide details on 0 work properly * Passing values to general ledger was stripping some correct records * Computed field for hiding lines doesn't have proper dependencies nor is not taking into account float currency accuracy

Currently translated at 21.5% (67 of 312 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/it/

Currently translated at 99.7% (311 of 312 strings) Translation: account-financial-reporting-11.0/account-financial-reporting-11.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-11-0/account-financial-reporting-11-0-account_financial_report/es/

* Fix wizards for proper multicompany behaviour. * Fix layout issue

- minor usability fixes for multicompany - improve performance of general ledger using a new index

norlinhenrik · 2024-02-28T14:05:29Z

I have cherry-picked 4 commits in total from 3 PRs (#1105, #1112, #1114).

victoralmau · 2024-03-13T10:57:32Z

Please, cherry-pick #1117

Steps: - Accounting > Reporting > OCA accounting reports > Journal Ledger - Select Date range and activate Foreign Currency Get "{'name': 'EUR'} " in currency field Desired: get EUR

victoralmau · 2024-03-19T12:04:56Z

Please cherry-pick #1136

HaraldPanten · 2024-03-22T11:35:08Z

@norlinhenrik You're still working on it, right? Did you have the opportunity to check the last comments from Victor?

THX.

…eneral ledger In v15 it was filtered by the internal_type field (type of account.account.type) to use "other" (most of the accounts had it set). Now in v16, there is the account_type field exists and has to be compatible. The in or not in operator is set to "simplify" the domain and avoid having to set almost all types.

HaraldPanten

Last commits have been added. I tested it in runboat and overall seems to be OK.

Functional review @victoralmau @pedrobaeza

pedrobaeza · 2024-03-26T15:55:06Z

/ocabot migration account_financial_report

pedrobaeza · 2024-03-26T16:18:31Z

account_financial_report/static/src/js/report_action.esm.js

-import {ReportAction} from "@web/webclient/actions/reports/report_action";
-import {patch} from "web.utils";
-import {useEnrichWithActionLinks} from "./report.esm";
+// /** @odoo-module **/


This feature is lost due to this commented:

patch(ReportAction.prototype, "account_financial_report.ReportAction", {
This line is causing error. How to do it in 17.0?

patch(ReportAction.prototype, { setup() {

this._super.apply(this, arguments);
TypeError: Cannot read properties of undefined (reading 'apply')

super.apply(...arguments);
TypeError: (intermediate value).apply is not a function

// super.apply(arguments);
TypeError: Cannot read properties of undefined (reading 'el')

super.setup(...arguments);
This worked

@pedrobaeza Could you check if last changes solves pending issues? Thanks

account_financial_report/wizard/general_ledger_wizard_view.xml

…_earnings_account

pedrobaeza

Working, thanks!

/ocabot merge nobump

OCA-git-bot · 2024-04-11T19:27:46Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1101-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-04-11T19:34:03Z

Congratulations, your PR was merged at 8361090. Thanks a lot for contributing to OCA. ❤️

rven · 2024-04-15T13:49:57Z

account_financial_report/wizard/abstract_wizard.py

+
+
+class AbstractWizard(models.AbstractModel):
+    _name = "account_financial_report_abstract_wizard"


The module name is giving errors when upgrading Odoo!

def validate_model(model):
if "" in model and "." not in model and not model.startswith("x_") and model not in _VALID_MODELS:
raise SleepyDeveloperError("{} seems to be a table name instead of model name".format(model))
return model

This one blocks the upgrade of Odoo to version v17.

Has someone else already ran into this problem?

That error is on migration scripts or Odoo code?

This error blocks the upgrade when using CLI command
python <(curl -s https://upgrade.odoo.com/upgrade) test -d <your db name> -t <target version>

We are facing this problem on different projects.
The answer of Odoo is that the module has an incorrect name and we should change it.

The v17 version of the module is not giving an error when installing it on a Vanilla Odoo instance.
I don't know why they are throwing this error...

Feel free to make a PR with _name = "account.financial.report.abstract.wizard"

Feel free to make a PR with _name = "account.financial.report.abstract.wizard"

Or
_name = "report.account_financial_report.abstract_wizard"

same that:

account-financial-reporting/account_financial_report/report/vat_report.py

Line 11 in 9f3c12b

_name = "report.account_financial_report.vat_report"

Yes _name = "report.account_financial_report.abstract_wizard" is even better.

But this is not going to help of course the migration from v14 :-)
Then it needs to be changed there also.
I logged a ticket at Odoo to exclude the abstract classes from this check...because it's not going to create a model at all.
The module works in a vanilla Odoo v17, so it's an upgrade issue.

The original name existing with only underscores is giving errors when upgrading to v17. This change has been discussed in OCA#1101

BT-astauder and others added 30 commits January 24, 2024 11:57

Increasing version because of #PR403

351fb17

Some changes in the databases been made in OCA#403, but no migration is needed.

move font-family from generic tags

5b55c55

[ADD] 11.0 account_financial_report: add filter by journals

7460763

To general ledger

[11][FIX] Replace partner_ids by journal_ids

2d880a4

[FIX] _transient_clean_rows_older_than() WHERE clause

f3538bb

remove account groups if hierarchy = 'none'

e7a10f3

account_financial_report: set backgroud-color to table

b2b5d19

[FIX] account_financial_report_qweb: Widget date for t-raw date (OCA#483

4c600b9

)

[FIX+IMP] account_financial_report: new README structure + fixes in u…

0f3d135

…sability

[IMP] account_financial_report: adapt the wizards to multicompany

da37e1f

add proper titles

1ffccff

[FIX] account_financial_report: multicompany+layout behaviour (OCA#498)

041ad8f

* Fix wizards for proper multicompany behaviour. * Fix layout issue

[account_financial_report]

c8c82d9

- minor usability fixes for multicompany - improve performance of general ledger using a new index

pedrobaeza requested a review from HaraldPanten February 28, 2024 15:37

[FIX] account_financial_report: show currency name instead of dictionary

94fb973

Steps: - Accounting > Reporting > OCA accounting reports > Journal Ledger - Select Date range and activate Foreign Currency Get "{'name': 'EUR'} " in currency field Desired: get EUR

HaraldPanten approved these changes Mar 26, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Mar 26, 2024

OCA-git-bot mentioned this pull request Mar 26, 2024

Migration to version 17.0 #1085

Open

4 tasks

pedrobaeza requested changes Mar 26, 2024

View reviewed changes

norlinhenrik force-pushed the 17.0-mig-account_financial_report branch from d653fba to b6effa7 Compare March 31, 2024 07:06

[IMP] account_financial_report: reversed variable only_one_unaffected…

03a3a6f

…_earnings_account

norlinhenrik force-pushed the 17.0-mig-account_financial_report branch from b6effa7 to 03a3a6f Compare March 31, 2024 07:12

[FIX] account_financial_report: report_action javascript

9f60cdf

norlinhenrik force-pushed the 17.0-mig-account_financial_report branch from 53abd98 to 9f60cdf Compare March 31, 2024 08:46

pedrobaeza approved these changes Apr 11, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 11, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 11, 2024

OCA-git-bot merged commit dce2190 into OCA:17.0 Apr 11, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 11, 2024

rven reviewed Apr 15, 2024

View reviewed changes

rven added a commit to DynAppsNV/account-financial-reporting that referenced this pull request May 10, 2024

[FIX] Rename wizard AbstractModel

48cb985

The original name existing with only underscores is giving errors when upgrading to v17. This change has been discussed in OCA#1101

rven mentioned this pull request May 10, 2024

[FIX] Rename wizard AbstractModel #1168

Closed

norlinhenrik deleted the 17.0-mig-account_financial_report branch May 30, 2024 07:22

traitrantrobz mentioned this pull request Jun 18, 2024

[17.0][MIG] account_financial_report_operating_unit : Migration to 17.0 OCA/operating-unit#686

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_financial_report #1101

[17.0][MIG] account_financial_report #1101

norlinhenrik commented Jan 24, 2024

norlinhenrik commented Feb 28, 2024

victoralmau commented Mar 13, 2024

victoralmau commented Mar 19, 2024

HaraldPanten commented Mar 22, 2024

HaraldPanten left a comment •

edited

Loading

pedrobaeza commented Mar 26, 2024

pedrobaeza Mar 26, 2024

norlinhenrik Mar 31, 2024

norlinhenrik Mar 31, 2024

norlinhenrik Mar 31, 2024

norlinhenrik Mar 31, 2024

jroigesapen Apr 8, 2024

pedrobaeza left a comment

OCA-git-bot commented Apr 11, 2024

OCA-git-bot commented Apr 11, 2024

rven Apr 15, 2024

rven Apr 15, 2024

pedrobaeza Apr 15, 2024

rven Apr 15, 2024

norlinhenrik Apr 16, 2024

FernandoRomera Apr 16, 2024

norlinhenrik Apr 16, 2024

rven Apr 16, 2024



		class AbstractWizard(models.AbstractModel):
		_name = "account_financial_report_abstract_wizard"

[17.0][MIG] account_financial_report #1101

[17.0][MIG] account_financial_report #1101

Conversation

norlinhenrik commented Jan 24, 2024

norlinhenrik commented Feb 28, 2024

victoralmau commented Mar 13, 2024

victoralmau commented Mar 19, 2024

HaraldPanten commented Mar 22, 2024

HaraldPanten left a comment • edited Loading

Choose a reason for hiding this comment

pedrobaeza commented Mar 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 11, 2024

OCA-git-bot commented Apr 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HaraldPanten left a comment •

edited

Loading