[15.0][IMP][account_financial_report]: add custom intervals for aged partner report #1083

ernesto-garcia-tecnativa · 2023-11-02T19:21:00Z

carolinafernandez-tecnativa · 2023-11-21T15:24:50Z

WIP

carolinafernandez-tecnativa · 2023-11-23T12:54:19Z

@pedrobaeza could you please check it now? Thanks

pedrobaeza · 2023-11-29T07:43:56Z

account_financial_report/models/account_age_report_configuration.py

+    name = fields.Char(required=True)
+    code = fields.Char(required=True)
+    account_age_report_config_id = fields.Many2one("account.age.report.configuration")
+    lower_limit = fields.Integer()


We talked here about putting only one value, so no need to check overlappings and missing gaps:

Configuration 1:

15

30

60

It means the first interval is from 0 to 15, the second from 16 to 30, and the third is 61+.

pedrobaeza · 2023-11-29T07:44:27Z

account_financial_report/models/res_company.py

+class ResCompany(models.Model):
+    _inherit = "res.company"
+
+    age_partner_config_id = fields.Many2one(


Don't store this in company.

pedrobaeza · 2023-11-29T07:44:43Z

account_financial_report/models/res_config_settings.py

+
+    default_age_partner_config_id = fields.Many2one(
+        "account.age.report.configuration",
+        related="company_id.age_partner_config_id",


Don't mix related and default_*. A default is for all companies.

pedrobaeza · 2023-11-29T07:45:20Z

account_financial_report/readme/DESCRIPTION.rst

@@ -14,3 +14,5 @@ currency used in account move lines is properly shown.

 In case that in an account has not been configured a second currency foreign
 currency balances are not available.
+
+Invoicing / Settings / Invoicing / OCA Aged Report Configuration you will be able to set dynamic intervals that will appear on the Aged Partner Balance


This should go better redacted on CONFIGURE.rst. And please respect 80 cols limit.

pedrobaeza · 2023-11-29T07:46:28Z

account_financial_report/report/aged_partner_balance_xlsx.py

-            return {
-                0: {"header": _("Partner"), "field": "name", "width": 70},
-                1: {
-                    "header": _("Residual"),


Residual and current columns should be respected, no matter the configuration.

pedrobaeza · 2023-11-29T07:49:00Z

account_financial_report/report/aged_partner_balance_xlsx.py

-                "field_final_balance": "older",
+        }
+        if not report.age_partner_config_id:
+            report_columns.update(


Maybe it's better to use a hidden configuration (with active=False) with all these lines, and prevent its removal than hardcode all these lines. What do you think?

pedrobaeza · 2023-11-29T07:49:47Z

account_financial_report/report/templates/aged_partner_balance.xml

-                <div class="act_as_cell" style="width: 9.64%;">91 - 120 d.</div>
-                <!--## older-->
-                <div class="act_as_cell" style="width: 9.64%;">> 120 d.</div>
+                <t t-if="not age_partner_config">


Here, it shouldn't be needed the if, as it should be already got in the Python structure.

If it is not added, it will show all columns and it is not correct.

pedrobaeza · 2023-11-29T07:50:01Z

account_financial_report/report/templates/aged_partner_balance.xml

-                    t-options="{'widget': 'monetary', 'display_currency': res_company.currency_id}"
-                />
-            </div>
+            <t t-if="not age_partner_config">


The same here: you shouldn't put an if.

pedrobaeza · 2023-11-29T07:50:11Z

account_financial_report/report/templates/aged_partner_balance.xml

@@ -216,30 +232,38 @@
                    </div>
                    <!--## amount_residual-->
                    <div class="act_as_cell" style="width: 6.00%;">Residual</div>
+                    <t t-if="not age_partner_config">


The same...

pedrobaeza · 2023-11-29T07:50:21Z

account_financial_report/report/templates/aged_partner_balance.xml

-                            >
-                                <t
-                                    t-out="line['current']"
+                    <t t-if="not age_partner_config">


And the same...

chienandalu

Could you resolve conflicts @carolinafernandez-tecnativa ?

carolinafernandez-tecnativa · 2024-03-13T17:50:39Z

Could you resolve conflicts @carolinafernandez-tecnativa ?

Done!

chienandalu · 2024-03-22T08:16:26Z

New conflicts :( When you can @carolinafernandez-tecnativa

…r report

carolinafernandez-tecnativa · 2024-03-27T15:57:47Z

@carolinafernandez-tecnativa several things:

I can't delete configuration lines.

It puts "Superior limit", but it should "Inferior limit" AFAIK, as it's the starting days from which the interval is activated.

Why having "code" and "name"? I think the code (for internal purposes) should be automatic. It can be the ID for example.

Thanks!
Fixed first 2 points, WIP with third point.

pedrobaeza · 2024-03-27T19:47:36Z

Tested on runboat, the limits are not working well.

Check the example in http://oca-account-financial-reporting-15-0-pr1083-c23b2616a35d.runboat.odoo-community.org with "Test customer", that has an invoice with due date 2024-03-27, and when reporting for that date, the amount appears in both the "Current" column and in "5 days" one. And you have to overpass 10 days to see the amount in the column "10 days". I think that the computation is still based on superior limit, not on inferior one.

pedrobaeza · 2024-04-03T18:11:35Z

It has still some edges:

For an interval with superior limit 1 and a invoice with due today, it appears in current debt + the 1 interval:

Totals are not taking into account:

carolinafernandez-tecnativa · 2024-04-04T17:49:24Z

It has still some edges:

For an interval with superior limit 1 and a invoice with due today, it appears in current debt + the 1 interval:

Totals are not taking into account:

Could you please check now?

I fw theses changes to v16

carolinafernandez-tecnativa · 2024-04-05T10:15:56Z

It has still some edges:

For an interval with superior limit 1 and a invoice with due today, it appears in current debt + the 1 interval:

Totals are not taking into account:

Could you please check now?

I fw theses changes to v16

Hi @pilarvargas-tecnativa could you please help us to validate? thanks

pilarvargas-tecnativa

I have run the test in runbot and the ranges in which the overdue invoices appear in the report are correct. Thanks 👍

pedrobaeza

Finally!

/ocabot merge minor

OCA-git-bot · 2024-04-09T06:34:39Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-04-09T06:34:42Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-04-09T06:34:56Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1083-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot · 2024-04-09T06:42:22Z

Congratulations, your PR was merged at 351f10e. Thanks a lot for contributing to OCA. ❤️

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 5 times, most recently from 9a73417 to 7dfbf94 Compare November 22, 2023 17:06

pedrobaeza added this to the 15.0 milestone Nov 29, 2023

pedrobaeza changed the title ~~[IMP][account_financial_report]: add custom intervals for aged partner report~~ [15.0][IMP][account_financial_report]: add custom intervals for aged partner report Nov 29, 2023

pedrobaeza requested changes Nov 29, 2023

View reviewed changes

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 2 times, most recently from 0c1f43c to fae7499 Compare December 1, 2023 16:00

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch from fae7499 to 6827961 Compare February 20, 2024 20:08

chienandalu reviewed Mar 13, 2024

View reviewed changes

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 2 times, most recently from af155c6 to 1b815a0 Compare March 13, 2024 17:50

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 10 times, most recently from a583107 to 0d75c78 Compare March 15, 2024 12:28

[IMP][account_financial_report]: add custom intervals for aged partne…

465236d

…r report

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch from 0d75c78 to 36931c3 Compare March 22, 2024 10:34

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 3 times, most recently from a225669 to c23b261 Compare March 27, 2024 16:45

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 2 times, most recently from 0df362e to 060727c Compare April 2, 2024 12:02

carolinafernandez-tecnativa mentioned this pull request Apr 2, 2024

[16.0][IMP][account_financial_report]: add custom intervals for aged partner report #1140

Merged

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch from 060727c to 736c524 Compare April 3, 2024 17:51

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch 2 times, most recently from 6242c40 to 441927a Compare April 4, 2024 17:38

pilarvargas-tecnativa approved these changes Apr 8, 2024

View reviewed changes

[IMP] account_financial_report: Continue improvement

7e08953

carolinafernandez-tecnativa force-pushed the 15.0-account_financial_report-custom-intervals branch from 441927a to 7e08953 Compare April 8, 2024 17:11

pedrobaeza approved these changes Apr 9, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 9, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 9, 2024

OCA-git-bot merged commit a8365e7 into OCA:15.0 Apr 9, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 9, 2024

pedrobaeza deleted the 15.0-account_financial_report-custom-intervals branch April 9, 2024 06:47

carolinafernandez-tecnativa mentioned this pull request Apr 15, 2024

[17.0][IMP] account_financial_report: add custom intervals for aged partner report #1147

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][IMP][account_financial_report]: add custom intervals for aged partner report #1083

[15.0][IMP][account_financial_report]: add custom intervals for aged partner report #1083

ernesto-garcia-tecnativa commented Nov 2, 2023

carolinafernandez-tecnativa commented Nov 21, 2023

carolinafernandez-tecnativa commented Nov 23, 2023

pedrobaeza Nov 29, 2023 •

edited

Loading

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

pedrobaeza Nov 29, 2023

carolinafernandez-tecnativa Dec 1, 2023

pedrobaeza Nov 29, 2023

pedrobaeza Nov 29, 2023

pedrobaeza Nov 29, 2023

chienandalu left a comment

carolinafernandez-tecnativa commented Mar 13, 2024

chienandalu commented Mar 22, 2024

carolinafernandez-tecnativa commented Mar 27, 2024

pedrobaeza commented Mar 27, 2024

pedrobaeza commented Apr 3, 2024

carolinafernandez-tecnativa commented Apr 4, 2024

carolinafernandez-tecnativa commented Apr 5, 2024

pilarvargas-tecnativa left a comment

pedrobaeza left a comment

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

[15.0][IMP][account_financial_report]: add custom intervals for aged partner report #1083

[15.0][IMP][account_financial_report]: add custom intervals for aged partner report #1083

Conversation

ernesto-garcia-tecnativa commented Nov 2, 2023

carolinafernandez-tecnativa commented Nov 21, 2023

carolinafernandez-tecnativa commented Nov 23, 2023

pedrobaeza Nov 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

carolinafernandez-tecnativa commented Mar 13, 2024

chienandalu commented Mar 22, 2024

carolinafernandez-tecnativa commented Mar 27, 2024

pedrobaeza commented Mar 27, 2024

pedrobaeza commented Apr 3, 2024

carolinafernandez-tecnativa commented Apr 4, 2024

carolinafernandez-tecnativa commented Apr 5, 2024

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

OCA-git-bot commented Apr 9, 2024

pedrobaeza Nov 29, 2023 •

edited

Loading