Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fp-011-locus-of-authority.md #2675

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Update fp-011-locus-of-authority.md #2675

merged 4 commits into from
Jan 31, 2025

Conversation

nataled
Copy link
Contributor

@nataled nataled commented Jan 24, 2025

Adding counter-examples

@nataled
Update fp-011-locus-of-authority.md
01bfe7e 
Adding counter-examples
@nataled nataled requested a review from nlharris January 24, 2025 14:29
@nataled nataled mentioned this pull request Jan 24, 2025
Closed
nlharris
nlharris reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't address @cthoyt's suggestions here; just edited what you already had.

principles/fp-011-locus-of-authority.md Outdated Show resolved Hide resolved
principles/fp-011-locus-of-authority.md Outdated Show resolved Hide resolved
nataled and others added 2 commits January 27, 2025 16:52
@nataled @nlharris
Update principles/fp-011-locus-of-authority.md
b75f193 
Co-authored-by: Nomi Harris <nlharris@users.noreply.github.com>
@nataled @nlharris
Update principles/fp-011-locus-of-authority.md
622ede1 
Co-authored-by: Nomi Harris <nlharris@users.noreply.github.com>
@nataled
Copy link
Contributor Author

nataled commented Jan 27, 2025

Thanks, Nomi. I accepted your changes. My changes already addressed the original suggestions.

@nataled nataled marked this pull request as ready for review January 27, 2025 21:54
@nataled
Copy link
Contributor Author

nataled commented Jan 28, 2025

@nlharris can you re-review? I accepted your suggested changes.

@nataled nataled merged commit 52b156c into master Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlharris nlharris nlharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nataled @nlharris