Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make relations test more strict - flag cases where an ontology uses RO with inconsistent semantics #136

Open
cmungall opened this issue Oct 15, 2024 · 3 comments

Comments

@cmungall
Copy link
Contributor

The BTO folks are using an RO relation "part of" without declaring it transitive:

BRENDA-Enzymes/BTO#43

This means that anyone who is using OWL reasoning will get mysteriously incomplete examples (people who use pre OWL graph walking are immune to the problem).

There is no indication of this problem here:
image

I think both BTO folks and users of BTO would welcome the ability to spot these kinds of issues ahead of time, and I am sure this applies to many ontologies too.

@cmungall
Copy link
Contributor Author

Note: if you are coming from a formal OWL background you might interpret what I'm asking for is that all modules must be extracted using SLME. This is logical but too onerous. I think as a practical common sense requirement we can come up with a certain set of axiom types that MUST be preserved for RO

@anitacaron
Copy link
Collaborator

In the dashboard, we consider the base artefact, which doesn't have any axiom from RO. If it is not available, we generate one from the full.

@cmungall
Copy link
Contributor Author

Good point. Ultimately I think we need two sets of (possibly overlapping) tests, one for base and one for release. But appreciate this might be a big change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants