-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More resilient conversions from strings #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks good for the most part.
Could you add some documentation to Suit::from_char
explaining that the character is case-insensitive?
Also, CI failed to run due to clippy failing (assumably because some clippy rule was updated). I already went ahead and reordered the CI steps and fixed the clippy error on master. As I was writing this, I saw you made a push fixing it on this feature branch, and while I appreciate the change, I'd suggest popping off that commit and making that a separate PR.
Hey! I've removed the CI-related commit, and I've added the documentation to the As I've done that, I see that I've done the case-insensitive implementation for the Value conversion in the |
Rewritten the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Card::from("AH")
works