Merge pull request #1097 from NullVoxPopuli/modernized-build

Modernization, use simpler babel transform, emit declarations to separate directory

.github/actions/assert-build/action.yml

@@ -7,14 +7,15 @@ runs:
     shell: bash
     run: |-
       echo '
-        target: ${{ env.dist }}
+        target: ember-resources/
         setup:
           run: pnpm build
           cwd: ./ember-resources
         expect: |
-          index.js
-          index.js.map
-          index.d.ts
+          dist/index.mjs
+          dist/index.mjs.map
+          declarations/index.d.ts
+
           
       ' >> assert-contents.config.yml
       npx assert-folder-contents

.github/workflows/ci.yml

@@ -75,20 +75,26 @@ jobs:
       - uses: wyvox/action-setup-pnpm@v3
         with:
           node-version: 18.18.1
-      - uses: ./.github/actions/download-built-package
+      - name: 'Build'
+        run: pnpm build
       - name: 'Change TS to ${{ matrix.typescript-scenario }}'
         run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
         working-directory: ./test-app
-      - name: 'Type checking'
 
+      # This has been really annoying
+      # due to injected dependencies :(
+      - name: 'Re-sync injected dependencies'
+        run: pnpm i -f
+      - name: 'Print Versions'
         run: |
           pnpm --filter "test-app*" exec tsc -v;
           pnpm --filter "test-app*" exec glint --version;
-          pnpm --filter "test-app*" exec glint;
-
-
 
+      - name: 'Type checking (built in types)'
+        run: pnpm --filter "test-app" exec glint;
 
+      - name: 'Type checking (DefinitelyTyped types)'
+        run: pnpm --filter "test-app-definitely-typed" exec glint;
 
   default_tests:
     name: Default Tests

.npmrc

@@ -6,3 +6,8 @@ auto-install-peers=false
 
 # we never want to use packages from the registry over what's in the workspace
 prefer-workspaces-packages=true
+
+# default is true, we do this to try to have more isolation
+# since we test with incompatible sets of TS types.
+shared-workspace-lockfile=false
+