From feaed5001e9e80570b8e24d9c35d22e49b305acc Mon Sep 17 00:00:00 2001
From: betocantu93 <betocantu93@gmail.com>
Date: Mon, 8 Jan 2024 23:10:03 +0100
Subject: [PATCH] fix: types

---
 addon/modifiers/attach-qr-scanner.ts |  8 ++++---
 types/ember-modifier.d.ts            | 34 ----------------------------
 2 files changed, 5 insertions(+), 37 deletions(-)
 delete mode 100644 types/ember-modifier.d.ts

diff --git a/addon/modifiers/attach-qr-scanner.ts b/addon/modifiers/attach-qr-scanner.ts
index a665991e..64226cd2 100644
--- a/addon/modifiers/attach-qr-scanner.ts
+++ b/addon/modifiers/attach-qr-scanner.ts
@@ -20,8 +20,11 @@ interface Named {
 type Positional = [MediaStream];
 
 export interface AttachQrScannerModifierSignature {
-  positional: Positional;
-  named: Named;
+  Element: HTMLCanvasElement;
+  Args: {
+    Positional: Positional;
+    Named: Named;
+  };
 }
 
 const DEFAULT_COLOR = '#FF3B58';
@@ -95,7 +98,6 @@ export default class AttachQrScannerModifier extends Modifier<AttachQrScannerMod
   tick() {
     if (!this.scanner.jsQR) return;
     if (!this.video || !this.canvas) return;
-    if (this.isDestroyed || this.isDestroying) return;
 
     if (this.video.readyState === this.video.HAVE_ENOUGH_DATA) {
       this.element.height = this.video.videoHeight;
diff --git a/types/ember-modifier.d.ts b/types/ember-modifier.d.ts
deleted file mode 100644
index 2cff4b98..00000000
--- a/types/ember-modifier.d.ts
+++ /dev/null
@@ -1,34 +0,0 @@
-interface ModifierArgs {
-  positional: unknown[];
-  named: { [key: string]: unknown };
-}
-
-interface IModifier<Args extends ModifierArgs = ModifierArgs> {
-  args: Args;
-  element: Element | null;
-  isDestroying: boolean;
-  isDestroyed: boolean;
-  didReceiveArguments(): void;
-  didUpdateArguments(): void;
-  didInstall(): void;
-  willRemove(): void;
-  willDestroy(): void;
-}
-
-type Owner = unknown;
-
-declare module 'ember-modifier' {
-  export default class Modifier<Args extends ModifierArgs = ModifierArgs>
-    implements IModifier<Args> {
-    args: Args;
-    element: Element | null;
-    isDestroying: boolean;
-    isDestroyed: boolean;
-    constructor(owner: Owner, args: Args);
-    didReceiveArguments(): void;
-    didUpdateArguments(): void;
-    didInstall(): void;
-    willRemove(): void;
-    willDestroy(): void;
-  }
-}