fix: types

NullVoxPopuli · Jan 8, 2024 · feaed50 · feaed50
1 parent db4dbd4
commit feaed50
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 37 deletions.
diff --git a/addon/modifiers/attach-qr-scanner.ts b/addon/modifiers/attach-qr-scanner.ts
@@ -20,8 +20,11 @@ interface Named {
 type Positional = [MediaStream];
 
 export interface AttachQrScannerModifierSignature {
-  positional: Positional;
-  named: Named;
+  Element: HTMLCanvasElement;
+  Args: {
+    Positional: Positional;
+    Named: Named;
+  };
 }
 
 const DEFAULT_COLOR = '#FF3B58';
@@ -95,7 +98,6 @@ export default class AttachQrScannerModifier extends Modifier<AttachQrScannerMod
   tick() {
     if (!this.scanner.jsQR) return;
     if (!this.video || !this.canvas) return;
-    if (this.isDestroyed || this.isDestroying) return;
 
     if (this.video.readyState === this.video.HAVE_ENOUGH_DATA) {
       this.element.height = this.video.videoHeight;

diff --git a/types/ember-modifier.d.ts b/types/ember-modifier.d.ts