More tests

Author: tpc9000

src/Connection.lua

@@ -26,7 +26,7 @@ function Connection:Disconnect()
     local SignalRef = self._Signal
     local Temp = SignalRef._HeadConnection
 
-    if (Temp == nil) then
+    if (not Temp) then
         return
     end
 
@@ -45,7 +45,7 @@ function Connection:Disconnect()
     SignalRef._ConnectionCount -= 1
 
     if (SignalRef._ConnectionCount == 0) then
-        SignalRef._HeadConnection = nil
+        SignalRef._HeadConnection = false
         SignalRef._OnConnectionsEmpty()
     end
 

src/init.lua

@@ -31,10 +31,19 @@ type Connection = Connection.Connection;
 
 export type XSignal<T...> = {
     WaitNoTimeout: (() -> (T...));
+    DisconnectAll: (() -> ());
+    Destroy: (() -> ());
     Connect: (((T...) -> ()) -> (Connection));
     Once: (((T...) -> ()) -> (Connection));
     Fire: ((T...) -> ());
     Wait: ((number?, boolean?) -> (T...));
+
+    waitNoTimeout: (() -> (T...));
+    disconnectAll: (() -> ());
+    connect: (((T...) -> ()) -> (Connection));
+    once: (((T...) -> ()) -> (Connection));
+    fire: ((T...) -> ());
+    wait: ((number?, boolean?) -> (T...));
 }
 type GenericConnection = RBXScriptConnection | {
     Disconnect: (GenericConnection) -> ();
@@ -213,11 +222,13 @@ XSignal.waitNoTimeout = XSignal.WaitNoTimeout
 
 --- Flushes all connections from the Signal.
 function XSignal:Destroy()
-    self._HeadConnection = false
-    self._ConnectionCount = 0
-    self._OnConnectionsEmpty()
+    local Head = self._HeadConnection
+
+    while (Head) do
+        Head:Disconnect()
+        Head = Head._Next
+    end
 end
-XSignal.destroy = XSignal.Destroy
 XSignal.DisconnectAll = XSignal.Destroy
 XSignal.disconnectAll = XSignal.Destroy
 

src/init.spec.lua

@@ -368,6 +368,55 @@ return function()
             Test:Fire()
             expect(RunCount).to.equal(0)
         end)
+
+        it("should not error on multiple disconnections", function()
+            local Test = XSignal.new()
+            local X = Test:Connect(function() end)
+            Test:DisconnectAll()
+
+            expect(function()
+                X:Disconnect()
+            end).never.to.throw()
+        end)
+
+        it("should not reconnect the whole chain when Reconnect is called, and should set Connected = false", function()
+            local Test = XSignal.new()
+            local Count = 0
+
+            local X = Test:Connect(function()
+                Count += 1
+            end)
+
+            local Y = Test:Connect(function()
+                Count += 1
+            end)
+
+            local Z = Test:Connect(function()
+                Count += 1
+            end)
+
+            expect(Count).to.equal(0)
+            Test:Fire()
+            expect(Count).to.equal(3)
+            Test:DisconnectAll()
+            Test:Fire()
+            expect(Count).to.equal(3)
+
+            Count = 0
+            X:Reconnect()
+            Test:Fire()
+            expect(Count).to.equal(1)
+
+            Count = 0
+            Z:Reconnect()
+            Test:Fire()
+            expect(Count).to.equal(2)
+
+            Count = 0
+            Y:Reconnect()
+            Test:Fire()
+            expect(Count).to.equal(3)
+        end)
     end)
 
     describe("XSignal.Extend", function()