Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 2.4.1 #159

Merged
merged 8 commits into from
May 21, 2024
Merged

Prepare release 2.4.1 #159

merged 8 commits into from
May 21, 2024

Conversation

KievDevel
Copy link
Contributor

Checklist

  • Ensure all user facing text is spell checked.
  • Bump version in package.json
  • Update changelog
  • Write tests if needed

@KievDevel KievDevel requested a review from boundlesscalm May 14, 2024 12:44
@github-actions GitHub Actions
Copy link

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

KievDevel
KievDevel commented May 14, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@KievDevel KievDevel added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels May 14, 2024
@KievDevel KievDevel requested a review from datenreisender May 14, 2024 12:53
@boundlesscalm @KievDevel
fix: sort channels correctly (#160)
5fba9b9 
* fix: sort channels correctly

sort() without an argument only sorts based on the first ASCII value
This would result in [20, 5].sort() => [20, 5]

* Update Changelog.md

---------

Co-authored-by: Sviatoslav Svitlychnyi <kiev.devel@gmail.com>
KievDevel
KievDevel commented May 15, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
greg-fer
greg-fer requested changes May 21, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
KievDevel
KievDevel commented May 21, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@KievDevel KievDevel requested a review from greg-fer May 21, 2024 12:54
KievDevel
KievDevel commented May 21, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@KievDevel KievDevel added doc not required All PRs either need "doc required" or "doc not required". and removed doc not required All PRs either need "doc required" or "doc not required". labels May 21, 2024
@KievDevel KievDevel merged commit 87a79fa into main May 21, 2024
4 of 5 checks passed
@KievDevel KievDevel deleted the release-2.4.1-prep branch May 21, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-fer greg-fer greg-fer approved these changes

@datenreisender datenreisender datenreisender approved these changes

@boundlesscalm boundlesscalm Awaiting requested review from boundlesscalm

Assignees
No one assigned
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KievDevel @datenreisender @greg-fer @boundlesscalm