Skip to content

Commit

Permalink
Merge pull request #41 from NordicSemiconductor/update/shared
Browse files Browse the repository at this point in the history
Update shared
  • Loading branch information
chunfantasy authored Jul 8, 2020
2 parents b98963a + 7a39ad6 commit 5671232
Show file tree
Hide file tree
Showing 12 changed files with 10 additions and 21 deletions.
1 change: 0 additions & 1 deletion lib/actions/warningActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ export function clearIncompatibleWarning() {
};
}


export function setCommunicationErrorWarning(message) {
return dispatch => {
dispatch({
Expand Down
3 changes: 1 addition & 2 deletions lib/components/AppSidePanelView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ const AppSidePanelView = ({ selectedTestMode }) => (
<PacketView />
<TransmitSetupView />
</>
)
}
)}
</>
);

Expand Down
10 changes: 3 additions & 7 deletions lib/components/ChannelView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ const ChannelView = ({
</div>
);


const delayLabel = channelMode === SettingsActions.DTM_CHANNEL_MODE.sweep
? 'Sweep delay'
: 'Update period';
Expand All @@ -93,22 +92,19 @@ const ChannelView = ({
<div className="app-sidepanel-component-slider">
{ChannelSlider('Channel', channel, onChannelChanged)}
</div>
)
}
)}
{channelMode === SettingsActions.DTM_CHANNEL_MODE.sweep
&& (
<div className="app-sidepanel-component-slider">
{ChannelSlider('Channel Low', channelLow, onChannelLowChanged)}
</div>
)
}
)}
{channelMode === SettingsActions.DTM_CHANNEL_MODE.sweep
&& (
<div className="app-sidepanel-component-slider">
{ChannelSlider('Channel High', channelHigh, onChannelHighChanged)}
</div>
)
}
)}

<div className="app-sidepanel-component-inputbox">
<Form>
Expand Down
1 change: 0 additions & 1 deletion lib/components/ChartView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ const ChartView = ({
receiveValueHistoryTicks[lastChannel.channel] = 0;
}


const currentChannelData = new Array(channelTotal).fill(0);
if (currentChannel !== undefined) {
currentChannelData[currentChannel] = Math.max(1, Math.max(...receiveValueHistory));
Expand Down
1 change: 0 additions & 1 deletion lib/components/ToggleChannelModeView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ const ToggleChannelModeView = ({
);
};


ToggleChannelModeView.propTypes = {
selected: PropTypes.string.isRequired,
onButtonClicked: PropTypes.func.isRequired,
Expand Down
3 changes: 1 addition & 2 deletions lib/components/TransmitSetupView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ const txPowerView = (boardType, txPowerIdx, txPowerUpdated, isRunning) => {
return txPowerUpdated(value);
}
return txPowerUpdated(txPowerIdx);
}
}
}}
max={maxDbmRangeValue}
min={0}
labels={label}
Expand Down
1 change: 0 additions & 1 deletion lib/containers/channelView.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { connect } from 'react-redux';
import ChannelView from '../components/ChannelView';
import * as SettingsActions from '../actions/settingsActions';


export default connect(
(state, props) => ({
...props,
Expand Down
1 change: 0 additions & 1 deletion lib/containers/otherSettingsView.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { connect } from 'react-redux';
import OtherSettingsView from '../components/OtherSettingsView';
import * as SettingsActions from '../actions/settingsActions';


export default connect(
(state, props) => ({
...props,
Expand Down
1 change: 0 additions & 1 deletion lib/containers/timeoutView.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { connect } from 'react-redux';
import TimeoutView from '../components/TimeoutView';
import * as SettingsActions from '../actions/settingsActions';


export default connect(
(state, props) => ({
...props,
Expand Down
1 change: 0 additions & 1 deletion lib/containers/toggleChannelModeView.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { connect } from 'react-redux';
import ToggleChannelModeView from '../components/ToggleChannelModeView';
import * as SettingsActions from '../actions/settingsActions';


export default connect(
(state, props) => ({
...props,
Expand Down
1 change: 0 additions & 1 deletion lib/containers/toggleTestModeView.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ import { connect } from 'react-redux';
import ToggleTestModeView from '../components/ToggleTestModeView';
import * as SettingsActions from '../actions/settingsActions';


export default connect(
(state, props) => ({
...props,
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@
"devDependencies": {
"chart.js": "^2.8.0",
"nrf-dtm-js": "git+https://github.com/NordicPlayground/nrf-dtm-js",
"pc-nrfconnect-devdep": "git+https://github.com/NordicSemiconductor/pc-nrfconnect-devdep.git#semver:3.4.0",
"pc-nrfconnect-shared": "git+https://github.com/NordicSemiconductor/pc-nrfconnect-shared.git#semver:^4.8.3",
"react": "16.13.1",
"react-chartjs-2": "^2.7.6",
"react-rangeslider": "^2.2.0"
"react-dom": "16.13.1",
"react-rangeslider": "^2.2.0",
"react-redux": "7.2.0"
},
"dependencies": {
"electron-store": "^3.2.0"
Expand Down

0 comments on commit 5671232

Please sign in to comment.