-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize to None
optional attributes
#7
Initialize to None
optional attributes
#7
Conversation
Please approve :) |
Please approve. |
Por favor aprobar el fix soluciona un error critico de la integración |
fcb4675
to
111f579
Compare
@Noltari Can you check this PR? , it could fix the issue with HA. Thanks |
Let me be crystal clear about this: stop pinging me for approving this PR. |
@Noltari te comprendo perfectamente, lo primero no debería afectarte que te hagan mil PR es tu código y actualizaras cuando quieras / puedas, piensa que debes sentirte orgulloso de tener un repo activo que requiere de tu intervención y no tomarlo como una molestia, a la final es tu perfil y estatus el que se ve mejorado o afectado por tus contribuciones, te pediría que no hicieras pagar a justos por pecadores y "dejar pasar unos días" a propósito, a la final la gente dejara de usar tu solución y buscara una alternativa y eso no te beneficia, un abrazo eres un crack. |
@Noltari I apologize for my behavior. This won't happen again. Thanks for your contribution. |
@Noltari, I completely feel and share your frustration. As a father of two and owner/maintainer of another open-sourced package, I totally share the sentiment that these "hobby" projects can only get our attention during our ever shrinking spare time. Apologies if I put too much pressure on your end. TBH, my intention with this PR was quite the opposite: trying to help and relieve you from that. I was also aware of the bank holiday we just had in Spain, and assumed you were enjoying your vacations. I sincerely hope my PR and DM to bring it to your attention didn't cause too much stress. That was never my intention. If so, sorry for that. I would love for you to reconsider your decision of waiting a few days. It'd be great if it could make it to the next weekly release of HASS 😇 |
Merged, thanks @afharo |
home-assistant/core#105168 highlighted this issue: some stations don't provide some attributes. Since they are not initialized to
None
, they'll throw an error when attempting to access them.