Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSOC'24 ENHANCING DATA.TABLE PROJECT DISCUSSION THREAD #1

Open
23 tasks done
Nj221102 opened this issue May 27, 2024 · 26 comments
Open
23 tasks done

GSOC'24 ENHANCING DATA.TABLE PROJECT DISCUSSION THREAD #1

Nj221102 opened this issue May 27, 2024 · 26 comments
Assignees
@Nj221102

Comments

@Nj221102
Copy link
Owner

Nj221102 commented May 27, 2024 •
edited
Loading

This is a issue opened for discussion related to ENHANCING DATA.TABLE PROJECT for the duration of GSOC'24.

Project description : In this coding project, the primary objective is to address issues from a backlog of over 1000 open issues in the "data.table package". These issues span various categories, including "bug fixes", "feature requests", and "documentation enhancements". The project aims to comprehensively improve the package by resolving critical issues and enhancing functionality.

Mentors: @Anirban166 @tdhock

List of Issues I am working on:

List of Pull requests submitted:
@Nj221102
Copy link
Owner Author

Hi @Anirban166 @tdhock is this repo and issue good for the project discussion, if any changes needed plz suggest, Looking forward to working with both of you, thanks for mentoring me :)

@Nj221102 Nj221102 self-assigned this May 27, 2024
@Nj221102
Copy link
Owner Author

Hi, @Anirban166 @tdhock as suggested i will start updating about the progress here.

28 may 2024

Worked on issue #4930 and submitted an Pull request for the same , Also working on completing the PR #6125, simultaneously working on some other issues like #5292, #6037

@Nj221102
Copy link
Owner Author

29 May 2024

worked on issue #6037 which was about adding a "How to convert your Depends dependency on data.table to Imports" section to datatable-importing vignette and another issue #5265 about freadR.c being missing from this list containing files with openmp directives.

Submitted PR's for the above mentioned issues:-

Waiting for review of :-

@Anirban166 @tdhock

@Nj221102
Copy link
Owner Author

Nj221102 commented May 31, 2024 •
edited
Loading

30 May 2024

worked on issue #5386 which was about introducing a arguement in dcast to allow users to turn the message "default to length" to an error, but after thorough discussion community came to conclusion of just upgrading that message to a warning , so that's what i have implemented in PR #6164 i submitted today.

Waiting for review of :-

sorry for late report , i had exams on 31st so i didn't get much time to work.
@Anirban166 @tdhock

@Nj221102
Copy link
Owner Author

Nj221102 commented Jun 1, 2024 •
edited
Loading

Hi @tdhock @Anirban166 , i have exams between 1 jun to 6 jun as well so i won't be able to contribute much in this period of time, sorry for informing late.

@Nj221102
Copy link
Owner Author

Hi @tdhock @Anirban166 just wanted to inform that my exams are officially over, it was scheduled to end on 6th but my practical assessment which were scheduled for 12-15 june got preponed to 7-10 june hence my unavailability on mentioned dates, from now on i will be available on daily basis.

@Nj221102
Copy link
Owner Author

11 june

worked on #4533 which was issue to add verbose arguement to forder for better control over the verbosity of output, particularly when forder is called internally by other functions, and also raised a PR for the issue :-

PR's ready for review :-

PR's still being worked on :-

@Nj221102
Copy link
Owner Author

Nj221102 commented Jun 13, 2024 •
edited
Loading

12 june

Didn't started working on any new issue as two draft PR's were still pending to work on, so today I worked on both of them :-

Completed them and now they ready for review :-

PR's ready for review :-

@Nj221102
Copy link
Owner Author

13 June

Worked on #5706, issue was a feature request of fwrite returning file path instead of null, Also raised the PR for the said issue.

PR's ready for review :-

@Nj221102
Copy link
Owner Author

14 - 17 june

Worked on multiple issues including #5074, #5031, #5389, #5292 and raised PR's for all of them, and worked on completing the previous PR's as well.

PR's ready for review :-

This was referenced Jun 19, 2024
Closed
Closed
@Nj221102
Copy link
Owner Author

18 june

Worked on multiple issues including #5130, #4846, and raised PR's for all of them, and worked on completing the previous PR's as well.

PR's ready for review :-

@Nj221102
Copy link
Owner Author

Nj221102 commented Jun 28, 2024 •
edited
Loading

19 - 26 June

Hi @tdhock @Anirban166, this week i have woked only on the issues caused by previous PR's which needed instant attention (like failing test or cmd check) due to being too busy :-

I wanted to inform you that on the 19th, I had to travel to my hometown because my grandmother was bedridden. Unfortunately, she passed away on the 21st. Since then, I have been dedicating most of my time to the funeral and various ceremonies. In our culture, these ceremonies extend over 12 days, so I may not be very available in the coming days.

I am aware that my project is already behind schedule, and I promise to work diligently to complete as much as I can once these ceremonies are over. For the next few days, I will focus on completing my existing PRs during any free time I have. Please keep an eye on these PRs for review :-

thanks.

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 7, 2024 •
edited
Loading

Hi @tdhock @Anirban166,

I am free from all the stuff related to the funeral and will start to contribute regularly. As midterm evaluations are close and I am behind on schedule, I want to inform you that I will give my best to complete my project as stated in the proposal. However, due to the recent events, we are short on time. I was thinking of extending the timeline by 4-5 weeks so we can complete everything within the allotted time. If that’s not recommended, I will try my best to complete it within the remaining time and am willing to finish any leftover tasks even after the program is over, as I am already planning to contribute to data.table regularly afterwards.

Thank you for your understanding.

@tdhock
Copy link

tdhock commented Jul 8, 2024

please complete everything during the alotted time

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 8, 2024

please complete everything during the alotted time

will give my best :)

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 16, 2024 •
edited
Loading

10-16 July

worked on two issues #3065 and #6236, #3065was about updating the documentation for Isoweek and #6236 was about setnames functions behaving differently while doing partial and full assignment with missing values, submitted two PR's for the mentioned issues :-

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 19, 2024 •
edited
Loading

17 -19 july

worked on multiple issues such as #6069, #5829 and #5357, but was only able to raise PR for #5357, still working on other two, here's the new PR :-

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 23, 2024 •
edited
Loading

23 july

worked on issue #4541, and raised a PR for the same :-

@tdhock
Copy link

tdhock commented Jul 29, 2024 •
edited
Loading

23 june

july?

@Nj221102
Copy link
Owner Author

Nj221102 commented Jul 29, 2024 •
edited
Loading

23 june

july?

ohh, i have written june instead of july by mistake, just noticed thanks for pointing out, fixed now.

@Nj221102
Copy link
Owner Author

Nj221102 commented Aug 6, 2024

7 Aug

Worked on issues #6323 and filed a Pull request for the same:-

@Nj221102
Copy link
Owner Author

Nj221102 commented Aug 6, 2024

@tdhock and @Anirban166

PR ready for review :-

work in progress :-

@Nj221102
Copy link
Owner Author

Nj221102 commented Aug 19, 2024 •
edited
Loading

Hi @tdhock @Anirban166,

As data.table is currently in a code freeze and the final submission date is upon us, I’m planning to submit all the work I’ve completed so far. I realize it may not fully meet expectations, and I apologize for that. To address the remaining tasks, I’ve cleared my schedule for the next two months and will be focusing on resolving outstanding issues, including working on Hindi translations.

Since I’m still new to open-source and have made several mistakes, I’ve decided to put in significant effort to improve my skills. If possible, I’d really appreciate your help with reviews and suggestions over the next couple of months. Thank you for all the support you’ve provided so far.

I’m considering submitting my project in a format similar to this submission by a student you mentored last year. Do you think this format is good enough, or could you recommend a better template? Thanks in advance for your guidance.

@Nj221102
Copy link
Owner Author

Hi @tdhock @Anirban166,

I've completed my GSoC '24 summary for the final evaluation and would appreciate it if you could review it. If there are any changes needed, please let me know. I plan to submit this summary for the final evaluation soon.

I'm also considering writing a detailed blog covering all the issues I worked on, but due to time constraints, I'll focus on submitting the summary for now. The blog will take more time to ensure it's comprehensive.

summary : https://nj221102.github.io/Nitish-gSoc-24/2024-08-24-gsoc'24-summary/

@tdhock
Copy link

tdhock commented Aug 26, 2024

that is ok
for your own sake (and future job opportunities) it would be better to write more details about your experience, maybe talk about a couple of the PRs you found were most challenging, and what was your solution.

@Nj221102
Copy link
Owner Author

Nj221102 commented Aug 26, 2024 •
edited
Loading

that is ok for your own sake (and future job opportunities) it would be better to write more details about your experience, maybe talk about a couple of the PRs you found were most challenging, and what was your solution.

sure working on it, thanks for advice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nj221102 Nj221102

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdhock @Nj221102