openjdk8 compile statically

[hlolli]

EDITED 28/04/2020: I was able to solve the static compilation problem. With these changes I can finally compile graalvm native images. I didn't pay much attention to linting etc, so don't hesitate to ask questions about my decision or potential blunders. I will very likely need to make similar changes to jdk11, but this brings me step closer to getting graalvm 20 to compile on nixpkgs.

Preface: plz help and/or look over, I've been struggling with this for few days. I've been able to build openjdk8 statically with patches pointed out here graalvm/openjdk8-jvmci-builder#11 (comment) I've been successfull with both musl and gcc (I think I'll be focusing on gcc since the official CE is distributed with gcc, but this could be irrelevant). Ending with the same error over and over
[deleted]

Motivation for this change

As part of upgrading graalvm8, I will need to use statically compiled openjdk8 as basis for jvmci8 to build native-image/substratevm. I believe the same applies for openjdk11, but I haven't reached that far yet.

Things done

• Added optional attribute "static" to openjdk8

• Added patches needed to compile statically in gcc and musl (gcc should work fine as I write this, musl I haven't tested for few days, darwin-clang I never tried so far).

• Bumped openjdk8 and adoptjdk-bin both to 252-b09

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

• Built on platform(s)

  • NixOS
  • macOS
  • other Linux distributions

• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

• Tested execution of all binary files (usually in ./result/bin/)

• Determined the impact on package closure size (by running nix path-info -S before and after)

• Ensured that relevant documentation is up to date

• Fits CONTRIBUTING.md.

[doronbehar]

Maybe that's not a helpful advice but still: why aren't you using https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/static.nix ? At least to place there the dependencies you override... And there's also pkgsStatic.

[hlolli]

@doronbehar I tested both with pkgsStatic and pkgsMusl but it doesn't matter in terms of this bug, and I think it doesn't make sense to call these packages as they increase the package size substantially, calling the dependencies individually, makes it possible to use the current stdenv throughout.

[hlolli]

I think I've discovered the reason: oracle/graal#1755 (comment)

 a JDK built with --enable-static-build=yes should not even run. In any case, when building a labsjdk binary, we actually build the JDK twice. First with --enable-static-build=yes and then with --enable-static-build=no. The .a files from the first build are preserved and then overlayed on the result of the second built.

PR ready for review (description is modified above)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/issue-building-graalvm-19-2-1-dependency-for-the-clj-kondo-package/6932/4

[skykanin]

Compiled openjdk8 using static = true and it worked just fine on my laptop (although it took some time 😄 as to be expected). Also tested out resulting java and javac binaries with a simple hello world program. LGTM 👍

[stale]

I marked this as stale due to inactivity. → More info

[Artturin]

feel free to upstream the patches and rebase if you or someone wants to get this in nixpkgs