Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported by @fufexan: fufexan/nix-gaming#233 (comment)
Resolved by enabling multi-arch in the FHS environment.
This matches the implementation used by Heroic:
nixpkgs/pkgs/games/heroic/fhsenv.nix
Lines 14 to 15 in 6fa3f3d
And the impl previously used by the upstream umu-launcher flake, before it was refactored to override the nixpkgs package:
https://github.com/Open-Wine-Components/umu-launcher/blob/0cac244cc89ee69bf33ad60a3953cfde188ee8a6/packaging/nix/umu-run.nix#L14
(Added by Open-Wine-Components/umu-launcher#252)
cc @LovingMelody
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.