Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.closure-linter: init at 2.3.19 #14550

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

chris-martin
Copy link
Contributor

Things done:
  • Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pSub pSub added the 8.has: package (new) This PR adds a new package label Apr 9, 2016
@FRidh
Copy link
Member

FRidh commented Apr 9, 2016

appears to be a Python 2.x only package judging from the build log

@FRidh
Copy link
Member

FRidh commented Apr 22, 2016

ping

@chris-martin
Copy link
Contributor Author

google/closure-linter#81 confirms that Python 3 is not supported.

@chris-martin
Copy link
Contributor Author

Updated to flag the package as disabled for python 3.x.

@FRidh FRidh merged commit 4cd92c5 into NixOS:master Apr 26, 2016
@chris-martin chris-martin deleted the closure-linter branch April 26, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants