-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure: looking-glass-client #368827
Comments
Also seeing the same error message. system: "x86_64-linux" |
I am seeing the identical error. |
Same issue |
Specifying to use gcc13 in nativeBuildInputs works. Looking into it it seems that there is a somewhat stale PR in the nanosvg repo that silences the warning causing the error memononen/nanosvg#256 . This is not my domain and Im unsure on how to best approach this situation. |
replacing the vendored nanosvg with the one from nixpkgs will fix the build.diff --git a/pkgs/by-name/lo/looking-glass-client/nanosvg-unvendor.diff b/pkgs/by-name/lo/looking-glass-client/nanosvg-unvendor.diff
new file mode 100644
index 000000000000..1fb7f2364f46
--- /dev/null
+++ b/pkgs/by-name/lo/looking-glass-client/nanosvg-unvendor.diff
@@ -0,0 +1,28 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 3755adc..55e1eb3 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -25,6 +25,7 @@ include(OptimizeForNative) # option(OPTIMIZE_FOR_NATIVE)
+ include(UninstallTarget)
+
+ find_package(PkgConfig)
++find_package(NanoSVG REQUIRED)
+ pkg_check_modules(FONTCONFIG REQUIRED IMPORTED_TARGET fontconfig)
+
+ option(ENABLE_OPENGL "Enable the OpenGL renderer" ON)
+@@ -106,7 +107,6 @@ include_directories(
+ ${PROJECT_SOURCE_DIR}/include
+ ${CMAKE_BINARY_DIR}
+ ${CMAKE_BINARY_DIR}/include
+- ${PROJECT_TOP}/repos/nanosvg/src
+ )
+
+ link_libraries(
+@@ -161,6 +161,7 @@ target_compile_definitions(looking-glass-client PRIVATE CIMGUI_DEFINE_ENUMS_AND_
+ target_link_libraries(looking-glass-client
+ ${EXE_FLAGS}
+ PkgConfig::FONTCONFIG
++ NanoSVG::nanosvg
+ lg_resources
+ lg_common
+ displayservers
diff --git a/pkgs/by-name/lo/looking-glass-client/package.nix b/pkgs/by-name/lo/looking-glass-client/package.nix
index 4f3dac659a38..973ca6ce4a0a 100644
--- a/pkgs/by-name/lo/looking-glass-client/package.nix
+++ b/pkgs/by-name/lo/looking-glass-client/package.nix
@@ -14,6 +14,7 @@
libffi,
expat,
libGL,
+ nanosvg,
libX11,
libxkbcommon,
@@ -69,6 +70,7 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-CqB8AmOZ4YxnEsQkyu/ZEaun6ywpSh4B7PM+MFJF0qU=";
stripLen = 1;
})
+ ./nanosvg-unvendor.diff
];
nativeBuildInputs = [
@@ -88,6 +90,7 @@ stdenv.mkDerivation (finalAttrs: {
nettle
fontconfig
libffi
+ nanosvg
]
++ lib.optionals xorgSupport [
libxkbcommon
|
There's an issue here that's somewhat relevant, I had to pin my nixpkgs to the commit specified within that issue previous to the issue occurring, and both my issue with llvm and this worked, so potentially a connection to a version bump in gcc? anywho configuring my nixpkgs input in my flake.nix as per below has worked around the issue for me,
|
- Fix looking-glass-client build error (NixOS/nixpkgs#368827) by switching package to stable. - Fix electron build errors in Heroic by switchin it to stable. - Enable CUPS printing and necessary avahi config. - Add ghostty flake for testing & fun.
Same issue here. |
Steps To Reproduce
Steps to reproduce the behavior:
nix build github:nixos/nixpkgs/634fd46801442d760e09493a794c4f15db2d0cbb#looking-glass-client
Build log
Build Log
Additional context
Metadata
"x86_64-linux"
Linux 6.12.5, NixOS, 25.05 (Warbler), 25.05.20241219.d70bd19
yes
yes
nix-env (Nix) 2.24.11
/etc/nix/path/nixpkgs
Notify maintainers
@alexbakker @babbaj @j-brn
Note for maintainers: Please tag this issue in your PR.
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: