Add optimize as an alias of optimise #11577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
requested changes
Sep 24, 2024
| @@ -27,3 +27,4 @@ struct CmdOptimiseStore : StoreCommand | |||
| }; | |||
|
|
|||
| static auto rCmdOptimiseStore = registerCommand2<CmdOptimiseStore>({"store", "optimise"}); | |||
| static auto rCmdOptimizeStore = registerCommand2<CmdOptimiseStore>({"store", "optimize"}); | |||
There was a problem hiding this comment.
(Not commenting on whether we want American-spelling aliases for commands.)
The correct way to create an alias is to add it aliases in src/nix/main.cc. That way it doesn't duplicate manpages etc., and there is one "canonical" spelling.
There was a problem hiding this comment.
Got it. Thanks for pointing me in the right direction.
On first glance an alias like this would work (nix optimize -> nix store optimise)
{"optimize", { AliasStatus::AcceptedShorthand, {"store", "optimise"}}},
but neither of these do intending nix store optimise -> nix store optimize:
{"store optimize", { AliasStatus::AcceptedShorthand, {"store", "optimise"}}},
{"optimize", { AliasStatus::AcceptedShorthand, {"optimise"}}},
Seems to be because rewriteArgs expects a one-word command (unless you quote the argument) and doesn't modify the sub-command. I'll see if I can figure something else out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow both
nix store optimiseandnix store optimize.Context
Closes #11326
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.