Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce mkStringNoCopy #11551

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Re-introduce mkStringNoCopy #11551

wants to merge 2 commits into from

Commits on Sep 19, 2024

  1. Re-introduce mkStringNoCopy 

    In b70d22b `mkStringNoCopy()` was renamed to
`mkString()`, but this is a bit risky since in code like

    vStringRegular.mkString("regular");

we want to be sure that the right overload is picked. (This is
especially problematic since the overload that takes an
`std::string_view` *does* allocate.)  So let's be explicit.
    @edolstra
    edolstra committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ceb8833 View commit details
    Browse the repository at this point in the history

  2. Use mkStringNoCopy for some more string literals

    @edolstra
    edolstra committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    561149b View commit details
    Browse the repository at this point in the history