Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Cropper not returning result if image is not edited at all & finish button is pressed #216

Open
energosai opened this issue Jan 10, 2025 · 3 comments

Comments

@energosai
Copy link

Hello,

We came across a bug on iOS wherein if a image is passed to the cropper & if without any editing, the user presses on the finish button (bottom-right), then the cropper is not giving any result, the promise is neither resolving nor rejecting. It just quits on itself. The expected output is the original image.

The same is working well on android. If the check icon (top-right) is pressed, without editing, it is giving the output result, which is equal to original image.

Looking forward to the fix very soon.

@baronha
Copy link
Member

baronha commented Jan 10, 2025

So what kind of situation do you want to be reasonable? Should I just close and not output any results? I find that the most reasonable

@energosai energosai reopened this Jan 10, 2025
@energosai
Copy link
Author

Our flow is: Camera opens -> user clicks a picture -> we pass this image to the cropper -> if the user doesn't edit it & clicks on the finish button on iOS, we are loosing out on the original image the user clicked using the camera.

Please return the original image as output of the cropper if no editing is done.

On android, it is working well, we are getting the original image as output, if the user doesn't do any editing.

@energosai
Copy link
Author

We have recorded a demo video of the above issue, please watch it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants