From a15a6604a7bf6df4ad0e6fcdcd31b5356a9771ba Mon Sep 17 00:00:00 2001 From: Nick Logozzo Date: Thu, 4 Jan 2024 19:34:52 -0500 Subject: [PATCH] GNOME - Fix DnD Not Working Fixes #354 --- NickvisionTagger.GNOME/Program.cs | 1 + NickvisionTagger.GNOME/Views/MainWindow.cs | 14 ++++++-------- .../Linux/org.nickvision.tagger.metainfo.xml.in | 1 + 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/NickvisionTagger.GNOME/Program.cs b/NickvisionTagger.GNOME/Program.cs index 4914dadf..9cbee4b4 100644 --- a/NickvisionTagger.GNOME/Program.cs +++ b/NickvisionTagger.GNOME/Program.cs @@ -34,6 +34,7 @@ public Program(string[] args) _mainWindowController = new MainWindowController(args); _mainWindowController.AppInfo.Changelog = @"* Fixed an issue where album art was not deleted correctly on delete tag action + * Fixed an issue where dragging and dropping a library was not working * Updated translations (Thanks everyone on Weblate!)"; _application.OnActivate += OnActivate; if (File.Exists(Path.GetFullPath(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)) + "/org.nickvision.tagger.gresource")) diff --git a/NickvisionTagger.GNOME/Views/MainWindow.cs b/NickvisionTagger.GNOME/Views/MainWindow.cs index 4fe7efb4..1d835b28 100644 --- a/NickvisionTagger.GNOME/Views/MainWindow.cs +++ b/NickvisionTagger.GNOME/Views/MainWindow.cs @@ -717,15 +717,13 @@ private bool OnCloseRequested(Gtk.Window sender, EventArgs e) /// Gtk.DropTarget.DropSignalArgs private bool OnDrop(Gtk.DropTarget sender, Gtk.DropTarget.DropSignalArgs e) { - var obj = e.Value.GetObject(); - if (obj is Gio.FileHelper file) + var file = new Gio.FileHelper(e.Value.GetObject()!.Handle, false); + var path = file.GetPath() ?? ""; + Console.WriteLine(path); + if (MusicLibrary.GetIsValidLibraryPath(path)) { - var path = file.GetPath() ?? ""; - if (MusicLibrary.GetIsValidLibraryPath(path)) - { - _controller.OpenLibraryAsync(path).Wait(); - return true; - } + Task.Run(async () => await _controller.OpenLibraryAsync(path)); + return true; } return false; } diff --git a/NickvisionTagger.Shared/Linux/org.nickvision.tagger.metainfo.xml.in b/NickvisionTagger.Shared/Linux/org.nickvision.tagger.metainfo.xml.in index d4264bf2..091b03a6 100644 --- a/NickvisionTagger.Shared/Linux/org.nickvision.tagger.metainfo.xml.in +++ b/NickvisionTagger.Shared/Linux/org.nickvision.tagger.metainfo.xml.in @@ -42,6 +42,7 @@

- Fixed an issue where album art was not deleted correctly on delete tag action

+

- Fixed an issue where dragging and dropping a library was not working

- Updated translations (Thanks everyone on Weblate!)