[DO NOT MERGE] draft playing around with EVM codebase #2153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
x/evm/keeper
andeth/rpc/pubsub
files to improve code clarity and functionality. The most important changes involve renaming variables for better readability, simplifying function signatures, and removing unnecessary return values.Codebase simplification:
x/evm/keeper/call_contract.go
: Simplified theCallContractWithInput
function by removing theevmObj
return value. [1] [2] [3] [4]x/evm/keeper/grpc_query.go
: Removed unnecessary return values in several functions, includingEthCall
,EstimateGasForEvmCallType
,TraceTx
,TraceCall
,TraceBlock
, andTraceEthTxMsg
. [1] [2] [3] [4] [5] [6]x/evm/keeper/msg_server.go
: Simplified theApplyEvmMsg
function by removing theevmObj
return value and renaming the function parameters for better readability. [1] [2] [3] [4] [5] [6]Variable renaming for better readability:
eth/rpc/pubsub/pubsub.go
: Renamed thename
parameter totopicName
in several functions to improve clarity. [1] [2] [3]Removal of unused code:
x/evm/keeper/keeper.go
: Removed theBaseFeeWeiPerGas
andTracer
functions as they were no longer needed.Minor bug fixes:
app/evmante/evmante_can_transfer.go
: Fixed a bug by usingctd.EVMKeeper.NewStateDB
instead ofctd.NewStateDB
.x/evm/keeper/funtoken_from_coin.go
: Removed an unnecessary return value in thedeployERC20ForBankCoin
function.# Purpose / Abstract