Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: general code style cleanups on precompile and statedb journal #2100

Merged
merged 24 commits into from
Oct 31, 2024

Merge branch 'main' into ud/db-cache

6dc3c9b
Select commit
Loading
Failed to load commit list.
Merged

refactor: general code style cleanups on precompile and statedb journal #2100

Merge branch 'main' into ud/db-cache
6dc3c9b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

64.57% (target 60.00%)

View this Pull Request on Codecov

64.57% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 65.71429% with 48 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (7b7beb7) to head (6dc3c9b).

Files with missing lines Patch % Lines
eth/rpc/rpcapi/websockets.go 0.00% 12 Missing ⚠️
x/evm/precompile/wasm_parse.go 64.00% 6 Missing and 3 partials ⚠️
x/evm/precompile/wasm.go 70.83% 4 Missing and 3 partials ⚠️
eth/rpc/rpcapi/eth_api.go 20.00% 4 Missing ⚠️
x/evm/precompile/errors.go 40.00% 2 Missing and 1 partial ⚠️
eth/rpc/rpc.go 0.00% 2 Missing ⚠️
x/evm/precompile/funtoken.go 71.42% 1 Missing and 1 partial ⚠️
x/evm/precompile/precompile.go 84.61% 1 Missing and 1 partial ⚠️
x/evm/statedb/statedb.go 0.00% 2 Missing ⚠️
cmd/nibid/cmd/base64.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2100      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.01%     
==========================================
  Files         271      271              
  Lines       21237    21223      -14     
==========================================
- Hits        13716    13705      -11     
+ Misses       6574     6569       -5     
- Partials      947      949       +2
Files with missing lines Coverage Δ
eth/eip712/eip712_legacy.go 75.00% <100.00%> (ø)
eth/eip712/encoding_legacy.go 76.40% <ø> (ø)
eth/eip712/message.go 81.92% <100.00%> (ø)
eth/rpc/backend/blocks.go 47.11% <100.00%> (ø)
eth/rpc/backend/tracing.go 50.00% <100.00%> (ø)
eth/rpc/backend/utils.go 62.98% <ø> (ø)
x/common/testutil/nullify.go 51.51% <100.00%> (ø)
x/devgas/v1/types/params.go 85.00% <100.00%> (ø)
x/epochs/types/identifier.go 100.00% <100.00%> (ø)
x/evm/keeper/grpc_query.go 79.92% <100.00%> (ø)
... and 20 more
View more details on Codecov