Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evm): improve safety of ERC20 transfers, accounting for boolean success return values and recipient balance changes that don't match the ERC20 transfer amount. #2090

Merged
merged 11 commits into from
Oct 30, 2024

fix: fix error message

f356315
Select commit
Loading
Failed to load commit list.
Merged

fix(evm): improve safety of ERC20 transfers, accounting for boolean success return values and recipient balance changes that don't match the ERC20 transfer amount. #2090

fix: fix error message
f356315
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Oct 23, 2024 in 0s

37.50% of diff hit (target 0.00%)

View this Pull Request on Codecov

37.50% of diff hit (target 0.00%)

Annotations

Check warning on line 595 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L595 

Added line #L595 was not covered by tests

Check warning on line 598 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L598 

Added line #L598 was not covered by tests

Check warning on line 622 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L622 

Added line #L622 was not covered by tests

Check warning on line 631 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L631 

Added line #L631 was not covered by tests

Check warning on line 635 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L635 

Added line #L635 was not covered by tests

Check warning on line 642 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L642 

Added line #L642 was not covered by tests

Check warning on line 645 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L645 

Added line #L645 was not covered by tests

Check warning on line 651 in x/evm/keeper/msg_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

x/evm/keeper/msg_server.go#L651 

Added line #L651 was not covered by tests
View more details on Codecov