refactor(evm): remove outdated comment and improper error message text

[Unique-Divine]

Purpose / Abstract

• Closes https://github.com/code-423n4/2024-10-nibiru-zenith/issues/38

Summary by CodeRabbit

• New Features

  • Enhanced gas calculation logic for Ethereum transactions to respect gas limits.
  • Improved event emission for transaction fees and priority determination.

• Improvements

  • Refined error handling and argument validation for better clarity and consistency.
  • Updated changelog format to better document project evolution and changes.

• Bug Fixes

  • Clarified error messages in argument validation to ensure consistent feedback.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes comprehensive updates to the CHANGELOG.md for the Nibiru project, detailing significant modifications across various sections such as "Unreleased," "Features," and "Bug Fixes." Notable changes involve enhancements to the Ethereum Virtual Machine (EVM) functionalities, updates to gas consumption validation in evmante_gas_consume.go, and improvements to error handling in oracle.go. The updates ensure clarity and maintainability in documentation and code structure, while also reflecting adjustments in dependencies and method signatures.

Changes

File Path	Change Summary
CHANGELOG.md	Comprehensive update to the changelog format and content, detailing unreleased features, improvements, bug fixes, and dependency updates.
app/evmante/evmante_gas_consume.go	Refined gas calculation logic in AnteHandle, updated error handling comments, preserved event emission logic, and adjusted gas meter configuration. Method signature for deductFee updated for clarity.
x/evm/precompile/oracle.go	Improved error handling in decomposeQueryExchangeRateArgs using assertNumArgs, with updated error messaging for argument validation. Method signature remains unchanged but internal logic modified.

Possibly related PRs

• feat(evm): add oracle precompile #2056: The changes in CHANGELOG.md for this PR include significant updates related to the Nibiru EVM, which are also reflected in the main PR's changelog updates, indicating a direct connection in documenting related changes.
• fix(evm-precompiles): add assertNumArgs validation #2060: This PR introduces the assertNumArgs validation, which is relevant to the changes in the CHANGELOG.md of the main PR, as both involve enhancements to the EVM's functionality and error handling.

Suggested reviewers

• onikonychev

🐇 In the changelog, we hop and play,
Documenting changes in a clear way.
Gas logic refined, errors now bright,
EVM features take flight,
With every update, we grow and sway,
Nibiru's journey, hip-hip-hooray! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.