Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/#44] 페이지 라우팅 연결 #45

Merged
merged 2 commits into from
Feb 5, 2025
Merged

[Feat/#44] 페이지 라우팅 연결 #45

merged 2 commits into from
Feb 5, 2025

Conversation

sikkzz
Copy link
Collaborator

@sikkzz sikkzz commented Feb 4, 2025

💡 변경사항 & 이슈

전체 페이지 라우팅 연결

✍️ 관련 설명

  • receipt-result -> review-result로 변경 (영수증 완료가 아니라 리뷰 생성 완료가 더 맞다 생각)
    • 리뷰 생성 로딩 UI로 추가 (원래는 페이지로 존재하던 컴포넌트)
  • 전체 페이지 라우팅 추가
    • PATH 상수 추가
    • useRoute hook에 전체 라우팅 함수 추가

임시용 라우팅들이 몇개 있는데 주석처리랑 같이 작성했고 이후에 네이티브 연결되면 다 바꿀 예정이야

#38 머지 이후 머지 예정

⭐️ Review point

  • 라우팅 빠진 부분 있는지
  • 이외 개선점

📷 Demo

.

@sikkzz sikkzz added the Feature new feature label Feb 4, 2025
@sikkzz sikkzz self-assigned this Feb 4, 2025
@sikkzz sikkzz requested a review from lgrin-byte as a code owner February 4, 2025 13:48
@sikkzz sikkzz linked an issue Feb 4, 2025 that may be closed by this pull request
[Feature] 페이지 라우팅 연결 #44
Closed
1 task
lgrin-byte
lgrin-byte approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@lgrin-byte lgrin-byte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔꼼 그자체,, 굳굳!!

@sikkzz sikkzz merged commit 831e247 into develop Feb 5, 2025
1 check passed
@sikkzz sikkzz deleted the feat/#44 branch February 5, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrin-byte lgrin-byte lgrin-byte approved these changes

Assignees

@sikkzz sikkzz

Labels
Feature new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 페이지 라우팅 연결
2 participants
@sikkzz @lgrin-byte