목표 상세 완료 다이얼로그 #83
Merged
목표 상세 완료 다이얼로그 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nohjunh
reviewed
Feb 21, 2025
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalScreen.kt
Outdated
Show resolved
Hide resolved
feature/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/DetailGoalViewModel.kt
Outdated
Show resolved
Hide resolved
...re/goal/src/main/kotlin/com/chipichipi/dobedobe/feature/goal/component/GoalCompleteDialog.kt
Outdated
Show resolved
Hide resolved
nohjunh
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lottie libs 추가했습니다
CompleteDialog UI 구현했습니다
ViewModel에서 goalUiEvent 를 추가했습니다!
init{} 에서 goal 상태를 관찰해서 uiEvent를 발행하도록 구현했습니다
isCompleted이 변경될 때마다 Event를 방출하도록 구현했습니다~목표 달성 버튼을 여러 번 빠르게 누를 경우, SnackBar 와 다이얼로그가 반복해서 뜨는 이슈가 있었습니다.
onShowSnackBar()에remeberCoroutineScope를 감싸주고, dialog를 보여줄 때 cancel 시켜주었습니다~Screen_Recording_20250222_012744_dobedobe.mp4