Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

대시보드에서 검색화면 이동할 때 BottomSheet PartiallyExpand 처리 #65

Conversation

murjune
Copy link
Member

@murjune murjune commented Feb 12, 2025

준혁님 말씀대로 AppState 에 DashBoard의 바텀시트의 상태를 가지고 있다는게 조금 어색하지만..
딱히 방법을 찾지 못했습니다 😂

검색화면으로 이동 할 경우, DashBoardScreen 의 BottomSheetScaffoldState 가 비활성화되어 PartiallyExpand 이 적용되지 않았습니다.
제시해주신 방안대로, BottomSheetScaffoldState를 App 단까지 호이스팅해서 처리했습니다~
한 수 또 배워갑니다 준혁님 ㅎㅎ

@murjune murjune self-assigned this Feb 12, 2025
@murjune murjune marked this pull request as ready for review February 12, 2025 04:18
@murjune murjune changed the base branch from develop to feat/dashboard-bottom-sheet February 12, 2025 04:18
@murjune murjune force-pushed the feat/dashboard-bottomsheet-partially-expand branch from b3c4a8f to e5639f9 Compare February 12, 2025 04:20
Copy link
Member

@nohjunh nohjunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 애매한 부분이 있긴 하지만, 최대한 단순하게 생각하면, BottomSheetScaffoldState를 호이스팅하는 게 요구사항 구현하기에는 제일 무난해보였어요!! 좋습니다!

@murjune murjune merged commit 98842f7 into feat/dashboard-bottom-sheet Feb 14, 2025
1 check passed
@murjune murjune deleted the feat/dashboard-bottomsheet-partially-expand branch February 14, 2025 15:41
murjune added a commit that referenced this pull request Feb 15, 2025
* chore: add systemBarInsetPadding

* feat: bottom sheet collapse when system back button trigger

* style: ktlintFormat

* feat: bottomSheetScaffoldState hoist to appState (#65)

* chore: add remember resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants