-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification 기반 잡기 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjune
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작업타임에 말했던 의견 때문에, 작업하느라 고민이 더 많이 되셨을 것 같네요 😵💫
고생 많으셨습니다!
core/designsystem/src/main/kotlin/com/chipichipi/dobedobe/core/designsystem/component/Dialog.kt
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/DashboardScreen.kt
Show resolved
Hide resolved
...notifications/src/main/kotlin/com/chipichipi/dobedobe/core/notifications/NotificationUtil.kt
Outdated
Show resolved
Hide resolved
...re/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/DashboardViewModel.kt
Show resolved
Hide resolved
...notifications/src/main/kotlin/com/chipichipi/dobedobe/core/notifications/NotificationUtil.kt
Outdated
Show resolved
Hide resolved
murjune
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
주말까지 고생 많으셨습니다~!!
* feat : Implement base for feature:setting * feat : Connect dashboard and settings navigation * feat : add temporary wrapping structure for Switch * feat : add openPlayStore Util * feat : add SettingTopAppBar component * feat : add SettingRow component * feat : Implement settings feature requirements * refactor : lint * refactor : Rename onSettingClick to navigateToSetting * refactor : Encapsulate settings UI elements within SettingBody * refactor : Rename isSystemNotificationEnabled to updatedSystemNotificationEnabled * refactor : Remove Box and use modifiers for layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification 기능을 위한 기반 작업입니다.