목표 리스트 바텀 시트 기본 UI 구현 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohjunh
reviewed
Jan 22, 2025
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/chipichipi/dobedobe/feature/dashboard/preview/GoalPreviewParameterProvider.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
nohjunh
reviewed
Jan 22, 2025
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
nohjunh
reviewed
Jan 22, 2025
...ain/kotlin/com/chipichipi/dobedobe/feature/dashboard/preview/GoalPreviewParameterProvider.kt
Show resolved
Hide resolved
nohjunh
reviewed
Jan 22, 2025
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
feat: designSystem BottomSheetScaffold base
murjune
force-pushed
the
feat/goal-list-modalsheet
branch
from
36737b2 to
acdaf63
Compare
|
ktLint 포메팅 같은 경우는 TODO 로 남겨두고 따로 PR 파서 한 방에 해결해보겠습니닷..acdaf63 |
nohjunh
approved these changes
Jan 23, 2025
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
|
추가로 기존 GoalContent -> GoalBottomSheetBody 로 네이밍 변경했습니다~ 2aec2ab |
nohjunh
reviewed
Jan 23, 2025
feature/dashboard/src/main/kotlin/com/chipichipi/dobedobe/feature/dashboard/GoalBottomSheet.kt
Outdated
Show resolved
Hide resolved
nohjunh
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BottomSheetScaffold 를 활용해서 GoalBottomSheet를 구현했습니다. 커스텀 해보려했는데.. 시간이 너무 오래걸리는 것 같아 일단 기본 제공 UI를 사용했네요
한가지 논의해볼만한 점이 있는데요! 기본적으로 보여야하는 BottomSheet 의 높이(=
peekHeight)를 얼마나 잡아야할 지 궁금하더라구요아마 오늘 회의 때 확정나겠죠??
추가로 :datastore-proto 의 경우 ktlint 적용을 제외했습니다~ ksp가 만들 코드가 컨벤션 위반해서 문제가 되는 것 같은데, 해결 방법을 일단 찾지 못했네요 😂