Skip to content

Commit

Permalink
chore: rename Event lambda, add private modifier
Browse files Browse the repository at this point in the history
  • Loading branch information
murjune committed Jan 31, 2025
1 parent d2911ee commit 61f0146
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ internal fun DobeDobeNavHost(
goalGraph(
onShowSnackbar = onShowSnackbar,
navigateToBack = navController::popBackStack,
saveSnackBarEvent = navController::saveSnackBarEvent,
sendSnackBarEvent = navController::saveSnackBarEvent,
)

settingScreen(
Expand Down Expand Up @@ -84,7 +84,7 @@ private fun GoalSnackBarEffect(
}
}

fun NavController.saveSnackBarEvent(
private fun NavController.saveSnackBarEvent(
type: GoalSnackBarType,
) {
val preBackStackEntry = previousBackStackEntry ?: return
Expand All @@ -93,6 +93,6 @@ fun NavController.saveSnackBarEvent(
}
}

fun NavBackStackEntry.removeSnackBarEvent() {
private fun NavBackStackEntry.removeSnackBarEvent() {
savedStateHandle.remove<GoalSnackBarType>(GoalSnackBarType.KEY)
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import org.koin.androidx.compose.koinViewModel
fun AddGoalRoute(
onShowSnackbar: suspend (String, String?) -> Boolean,
navigateToBack: () -> Unit,
saveSnackBarEvent: (GoalSnackBarType) -> Unit,
sendSnackBarEvent: (GoalSnackBarType) -> Unit,
viewModel: AddGoalViewModel = koinViewModel(),
) {
val lifecycle = LocalLifecycleOwner.current.lifecycle
Expand All @@ -46,7 +46,7 @@ fun AddGoalRoute(
LaunchedEffect(Unit) {
viewModel.addGoalEvent
.onEach {
saveSnackBarEvent(GoalSnackBarType.ADD)
sendSnackBarEvent(GoalSnackBarType.ADD)
onBack()
}
.flowWithLifecycle(lifecycle)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import org.koin.androidx.compose.koinViewModel
@Composable
internal fun DetailGoalRoute(
onShowSnackbar: suspend (String, String?) -> Boolean,
saveSnackBarEvent: (GoalSnackBarType) -> Unit,
sendSnackBarEvent: (GoalSnackBarType) -> Unit,
navigateToBack: () -> Unit,
modifier: Modifier = Modifier,
viewModel: DetailGoalViewModel = koinViewModel(),
Expand All @@ -57,7 +57,7 @@ internal fun DetailGoalRoute(
val focusManager = LocalFocusManager.current
val onBack = {
if (isGoalChanged) {
saveSnackBarEvent(GoalSnackBarType.EDIT)
sendSnackBarEvent(GoalSnackBarType.EDIT)
}
focusManager.clearFocus()
navigateToBack()
Expand All @@ -70,7 +70,7 @@ internal fun DetailGoalRoute(
LaunchedEffect(Unit) {
viewModel.deleteGoalEvent
.onEach {
saveSnackBarEvent(GoalSnackBarType.REMOVE)
sendSnackBarEvent(GoalSnackBarType.REMOVE)
onBack()
}
.flowWithLifecycle(lifecycle)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,22 @@ fun NavController.navigateToGoalDetail(

fun NavGraphBuilder.goalGraph(
onShowSnackbar: suspend (String, String?) -> Boolean,
saveSnackBarEvent: (GoalSnackBarType) -> Unit,
sendSnackBarEvent: (GoalSnackBarType) -> Unit,
navigateToBack: () -> Unit,
) {
composable<GoalRoute.Add> {
AddGoalRoute(
onShowSnackbar = onShowSnackbar,
navigateToBack = navigateToBack,
saveSnackBarEvent = saveSnackBarEvent,
sendSnackBarEvent = sendSnackBarEvent,
)
}

composable<GoalRoute.Detail> {
DetailGoalRoute(
onShowSnackbar = onShowSnackbar,
navigateToBack = navigateToBack,
saveSnackBarEvent = saveSnackBarEvent,
sendSnackBarEvent = sendSnackBarEvent,
)
}
}

0 comments on commit 61f0146

Please sign in to comment.