bug: aws 인스턴스에 환경변수 전달 안되는 문제 수정 및 docker compose 파일 db에 의존성 가지게 수정 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injoon2019
commented
Jul 19, 2024
deploy.sh
Outdated
Comment on lines
26
to
27
|
|
||
| rm /home/$SERVER_USER_NAME/deploy/env_vars.sh |
There was a problem hiding this comment.
일단 rm넣지 말고 파일 어떻게 생성되나 디버깅해도 좋을거 같기도하고.. 어떻게 생각하시나요?
There was a problem hiding this comment.
rm 하는 부분 제거했어요. pr 머지하고 원격접속해서 파일 확인해보면 좋을거 같아
There was a problem hiding this comment.
아하 여기서 rm 제거하고 환경변수 설정할 때 파일이 존재하면 삭제하는걸로 바꾼거죠?
injoon2019
commented
Jul 19, 2024
| @@ -19,7 +17,7 @@ services: | |||
| ports: | |||
| - "8080:8080" | |||
| depends_on: | |||
| - mysql | |||
There was a problem hiding this comment.
이거 아래 db에 의존성이 있는거 같아 수정했어요!
injoon2019
commented
Jul 19, 2024
| export DB_USER_NAME=${{ secrets.DB_USER_NAME }} | ||
| export DB_PASSWORD=${{ secrets.DB_PASSWORD }} | ||
| export DISCORD_WEBHOOK_URL=${{ secrets.DISCORD_WEBHOOK_URL }} | ||
| echo "SERVER_NGINX_CONF=${{ secrets.SERVER_NGINX_CONF }}" > /home/$SERVER_USER_NAME/deploy/env_vars.sh |
There was a problem hiding this comment.
일단 디버깅도 할겸 파일로 써볼까 합니다! export가 해당 세션 및 자식 세션에서 환경 변수가 유지된다고 하는데 끊기는건가 싶기도하네요
There was a problem hiding this comment.
좋아요! 이상하게 deploy.sh -> notify_error.sh 까지 환경변수가 잘 전달되는데 docker-compose.yml에서만 인식을 못하더라구요..
miseongk
approved these changes
Jul 20, 2024
Comment on lines
60
to
62
| if [ -f /home/$SERVER_USER_NAME/deploy/env_vars.sh ]; then | ||
| rm /home/$SERVER_USER_NAME/deploy/env_vars.sh | ||
| fi |
There was a problem hiding this comment.
SERVER_USER_NAME도 ${{ secrets.SERVER_USER_NAME }} 이렇게 해야하지 않을까요?!
There was a problem hiding this comment.
오 감사합니다 수정했어요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 이슈 번호
#4
✨ 작업 내용
🚀 전달 사항