Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for automated version bump #208

Closed
jasonlyik opened this issue May 8, 2024 · 8 comments · Fixed by #209
Closed

Workflow for automated version bump #208

jasonlyik opened this issue May 8, 2024 · 8 comments · Fixed by #209
Assignees

Comments

@jasonlyik
Copy link
Contributor

Everytime we merge to main, upload a new version to pypi.

Separately, can also automate readthedocs build

@ben9809 ben9809 linked a pull request May 12, 2024 that will close this issue
@jasonlyik
Copy link
Contributor Author

The current workflow automatically publishes to PyPi whenever there is a new release tag on main branch.

Still manual is building the documentation and also creating the repo release.

@ben9809
Copy link
Contributor

ben9809 commented May 21, 2024

Hi @jasonlyik, I see that the workflow to publish the package on Pypi has failed because of the authentication token

Regarding the documentation, I think we need to look into readthedocs options to auto-build the documentation on the main branch

@jasonlyik
Copy link
Contributor Author

Yup, I've added the required Trusted Publisher settings on Pypi to solve that issue. For now, I didn't want to delete and re-make the 1.0.4 tag, so I manually published it, but I believe when we reach 1.0.5 there should be no further issues.

For the documentation, sounds good. I think we should honestly get rid of the documentation branch, it is not different from the dev branch and the docs are stable enough now that we can just update on main like you say.

@jasonlyik
Copy link
Contributor Author

@ben9809 Looks like the automated flow for publishing hasn't been fixed by adding this repo as trusted published. I think it's because poetry publish isn't supported in a Github action.

Based on this: python-poetry/poetry#7940 (comment)

So I've made some updates to the script: 479a710

But I'm not sure how to test whether or not the action works, do you think I should pull it into main and delete / remake the tag?

@ben9809
Copy link
Contributor

ben9809 commented Jun 5, 2024

@jasonlyik It seems strange it's not supported, because I've already implemented this workflow for another open-source project and it os still working.

In the meantime try to delete/remake the tag to test if it works with the new workflow

@ben9809
Copy link
Contributor

ben9809 commented Jun 5, 2024

From the error message it seems like there is a problem with the authentication token.
Has PYPI_API_TOKEN secret been set?

@jasonlyik
Copy link
Contributor Author

Got it set, and the action was successful! Quick check of 1.0.5 and everything is good

@ben9809
Copy link
Contributor

ben9809 commented Jun 5, 2024

Great 💪🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants