Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit afprun functionality (preexec, postexec) #550

Closed
rdmark opened this issue Oct 21, 2023 · 4 comments · Fixed by #1849
Closed

Revisit afprun functionality (preexec, postexec) #550

rdmark opened this issue Oct 21, 2023 · 4 comments · Fixed by #1849
Assignees
Milestone

Comments

@rdmark
Copy link
Member

rdmark commented Oct 21, 2023

Like we did with 2.x in #526 I think afprun functionality should be removed from 3.x as well. Including the preexec / postexec, as well as the nostat options.

As with previous feature deprecations in 3.x, let me ask the community on the mailing lists about their use cases.

@rdmark rdmark changed the title Remove afprun functionality Remove afprun functionality (preexec, postexec) Dec 1, 2023
@rdmark
Copy link
Member Author

rdmark commented Dec 1, 2023

Inconclusive feedback from the community so far. Thread starts at https://sourceforge.net/p/netatalk/mailman/message/47401127/

@dgsga What do you think? There is an argument by Ralph that there is a general usecase for this feature, but noone in the community spoke up to say that they actually used it.

@rdmark rdmark changed the title Remove afprun functionality (preexec, postexec) Revisit afprun functionality (preexec, postexec) Dec 17, 2023
@rdmark
Copy link
Member Author

rdmark commented Dec 17, 2023

For this ticket I want to pivot to:

  1. Understanding what the concrete use cases are for this functionality. What kinds of volume pre-mount and post-dismount steps are actually executed? Is root privileges actually required?
  2. Revisit how this functionality is implemented (in particular around root access.)

@ghost
Copy link

ghost commented Dec 19, 2023

My take on it is that afprun functionality should be removed for this one reason alone:
"This code constitutes a major opportunity to run arbitrary shell commands (with root privileges) on the host, with all sorts of security implications."

@rdmark
Copy link
Member Author

rdmark commented Dec 19, 2023

How about the take the middle road of removing root preexec and root postexec while keeping the non-root functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant