-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix(runtime): Non-standard Concatenation Algorithm in BOM URL polyfill #17472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TechQuery
wants to merge
2
commits into
NervJS:main
Choose a base branch
from
idea2app:fix-URL-polyfill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
describe('BOM', () => { | ||
process.env.FRAMEWORK = 'nerv' | ||
const runtime = require('../../dist/runtime.esm') | ||
global.window = runtime.window | ||
|
||
afterAll(() => { | ||
process.env.FRAMEWORK = '' | ||
}) | ||
|
||
describe('URL', () => { | ||
it('URL 构造函数的 path 和 base 参数拼接算法', () => { | ||
const doubleSlashURL = new URL('//double/slash/path', 'https://example.com/') + '' | ||
expect(doubleSlashURL).toBe('https://double/slash/path') | ||
|
||
const absoluteURL1 = new URL('/absolute/path', 'https://example.com/') + '' | ||
expect(absoluteURL1).toBe('https://example.com/absolute/path') | ||
|
||
const absoluteURL2 = new URL('/absolute/path', 'https://example.com/exist/path') + '' | ||
expect(absoluteURL2).toBe('https://example.com/absolute/path') | ||
|
||
const relativeURL1 = new URL('relative/path', 'https://example.com/exist/path') + '' | ||
expect(relativeURL1).toBe('https://example.com/exist/relative/path') | ||
|
||
const relativeURL2 = new URL('relative/path', 'https://example.com/exist/path/') + '' | ||
expect(relativeURL2).toBe('https://example.com/exist/path/relative/path') | ||
}) | ||
|
||
it('URL path 折叠算法', () => { | ||
const currentPath1 = new URL('./current/path', 'https://example.com/exist/path/') + '' | ||
expect(currentPath1).toBe('https://example.com/exist/path/current/path') | ||
|
||
const currentPath2 = new URL('./current/path', 'https://example.com/exist/path') + '' | ||
expect(currentPath2).toBe('https://example.com/exist/current/path') | ||
|
||
const parentPath1 = new URL('../parent/path', 'https://example.com/exist/path/') + '' | ||
expect(parentPath1).toBe('https://example.com/exist/parent/path') | ||
|
||
const parentPath2 = new URL('../parent/path', 'https://example.com/exist/path') + '' | ||
expect(parentPath2).toBe('https://example.com/parent/path') | ||
|
||
const parentPath3 = new URL('../../parent/path', 'https://example.com/exist/path/') + '' | ||
expect(parentPath3).toBe('https://example.com/parent/path') | ||
|
||
const parentPath4 = new URL('../../parent/path', 'https://example.com/exist/path') + '' | ||
expect(parentPath4).toBe('https://example.com/parent/path') | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
个人觉得这个不如之前的写法清晰易读
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在同一份数据涉及的操作不多时,展开写可能更清晰;但分支情况多了,代码行数多反而不利于阅读,格式化规范的三目运算符则能清晰展示不同条件和分支的相互关系。