Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies like PHPUnit after official PHP 8.4 release #201

Closed
schakko opened this issue Sep 13, 2024 · 0 comments
Closed

Update dependencies like PHPUnit after official PHP 8.4 release #201

schakko opened this issue Sep 13, 2024 · 0 comments
Assignees
@schakko
Labels
dependencies php-8.4
Milestone
3.1.8

Comments

@schakko
Copy link
Member

schakko commented Sep 13, 2024 •
edited
Loading

PHP 8.4 is currently only available as RC. NADI itself works with PHP 8.4 but dev-dependencies like prophecy are not compatible yet (phpspec/prophecy#624).

  1. PHPUnit's 9.6.20 PHAR from the GH Action php-actions/phpunit@v2 contains prophecy. So PHPUnit has to be updated to 10.5.40 as a dependency. We skip 11.x for now.
  2. As 10up/wp_mock sitll requires PHPUnit 9.6.20, we have to overwrite the dependency manually in composer.json so that 10.5.40 also behaves as 9.6.20
  3. All unit tests have to be migrated to PHPUnit 10.x.
@schakko schakko self-assigned this Sep 13, 2024
schakko added a commit that referenced this issue Jan 9, 2025
@schakko
ci: WIP: PHP 8.4 (#201)
124c7a8 
Signed-off-by: Christopher Klein <ckl@dreitier.com>
@schakko schakko changed the title Update dependencies after official PHP 8.4 release Update dependencies like PHPUnit after official PHP 8.4 release Jan 9, 2025
schakko added a commit that referenced this issue Jan 9, 2025
@schakko
chore: Update dependencies like PHPUnit after official PHP 8.4 release (
50a880f 
#201)

Signed-off-by: Christopher Klein <ckl@dreitier.com>
schakko added a commit that referenced this issue Jan 9, 2025
@schakko
chore: Update dependencies like PHPUnit after official PHP 8.4 release (
534523e 
#201)

Signed-off-by: Christopher Klein <ckl@dreitier.com>
schakko added a commit that referenced this issue Jan 9, 2025
@schakko
chore: Update dependencies like PHPUnit after official PHP 8.4 release (
30c723c 
#201)

Signed-off-by: Christopher Klein <ckl@dreitier.com>
schakko added a commit that referenced this issue Jan 9, 2025
@schakko
chore: Update dependencies like PHPUnit after official PHP 8.4 release (
2f2f42b 
#201)

Signed-off-by: Christopher Klein <ckl@dreitier.com>
@schakko schakko added this to the 3.1.8 milestone Jan 9, 2025
@schakko schakko closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schakko schakko

Labels
dependencies php-8.4
Projects
None yet
Milestone
3.1.8
Development

No branches or pull requests
1 participant
@schakko